Skip to content

Download button is wrong #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
matklad opened this issue Jul 14, 2016 · 4 comments · Fixed by #9
Closed

Download button is wrong #7

matklad opened this issue Jul 14, 2016 · 4 comments · Fixed by #9
Assignees

Comments

@matklad
Copy link
Member

matklad commented Jul 14, 2016

Download button at the main page feels weird. Preferably, the user should never see the ugly plugins.jetbrains.com.

What do you think about the following UI: the button says Install, and it is simply a link to a page which explains how to install alpha/nightly channel from within IDE?

@mkaput
Copy link
Member

mkaput commented Jul 14, 2016

👍

But maybe instead of separate page, some (maybe animated) pop-over or iTunes-like sliding pane?

@matklad
Copy link
Member Author

matklad commented Jul 14, 2016

I first also thought about revealing this info via an animation, but it has a couple of drawbacks:

  • harder to implement
  • harder to get right for specific use cases like disabled JavaScript or accessibility
  • a dedicated Installation page will have an URL, which you can share

@mkaput
Copy link
Member

mkaput commented Jul 14, 2016

harder to implement

Hmm (not tested)

document.getElementById("download-stable")
    .addEventListener("click", function(e) {
        document.getElementById("download-pane").classList.toggle("visible");
    });

and then some CSS Transition magic 😄 HTML5 is awesome!

harder to get right for specific use cases like disabled JavaScript or accessibility
a dedicated Installation page will have an URL, which you can share

Hmm, what about mixing these two approaches? Download page's contents will be put inside a partial template. It will be rendered as an animated pane on the front page and as a separate page. Download button will point to that separate page. Two birds killed with one stone.

@matklad
Copy link
Member Author

matklad commented Jul 14, 2016

Yep, this is the best approach.

@mkaput mkaput mentioned this issue Jul 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants