Skip to content

Commit 6def975

Browse files
committed
Fix-478 incremental update
Signed-off-by: Bala Raman <[email protected]>
1 parent 681db17 commit 6def975

File tree

1 file changed

+30
-7
lines changed

1 file changed

+30
-7
lines changed

dockerfile_functions.sh

Lines changed: 30 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -261,7 +261,7 @@ EOI
261261
# Select the ubi OS packages.
262262
print_ubi_pkg() {
263263
cat >> "$1" <<'EOI'
264-
RUN dnf install -y tzdata openssl curl ca-certificates fontconfig glibc-langpack-en gzip tar binutils \
264+
RUN dnf install -y tzdata openssl curl ca-certificates fontconfig glibc-langpack-en gzip tar \
265265
&& dnf update -y; dnf clean all
266266
EOI
267267
}
@@ -270,15 +270,15 @@ EOI
270270
# Select the ubi OS packages.
271271
print_ubi-minimal_pkg() {
272272
cat >> "$1" <<'EOI'
273-
RUN microdnf install -y tzdata openssl curl ca-certificates fontconfig glibc-langpack-en gzip tar binutils \
273+
RUN microdnf install -y tzdata openssl curl ca-certificates fontconfig glibc-langpack-en gzip tar \
274274
&& microdnf update -y; microdnf clean all
275275
EOI
276276
}
277277

278278
# Select the CentOS packages.
279279
print_centos_pkg() {
280280
cat >> "$1" <<'EOI'
281-
RUN yum install -y tzdata openssl curl ca-certificates fontconfig gzip tar binutils \
281+
RUN yum install -y tzdata openssl curl ca-certificates fontconfig gzip tar \
282282
&& yum update -y; yum clean all
283283
EOI
284284
}
@@ -477,10 +477,30 @@ EOI
477477
}
478478

479479
# Call the script to create the slim package for Ubi
480-
# Using binutils package installed at startup for the "strip" command
481-
# Same function used for ubi-minimal, centos and clefos
482480
print_ubi_slim_package() {
483481
cat >> "$1" <<-EOI
482+
export PATH="${jhome}/bin:\$PATH"; \\
483+
dnf install -y binutils; \\
484+
/usr/local/bin/slim-java.sh ${jhome}; \\
485+
dnf remove -y binutils; \\
486+
dnf clean all; \\
487+
EOI
488+
}
489+
490+
# Call the script to create the slim package for Ubi
491+
print_ubi-minimal_slim_package() {
492+
cat >> "$1" <<-EOI
493+
export PATH="${jhome}/bin:\$PATH"; \\
494+
microdnf install -y binutils; \\
495+
/usr/local/bin/slim-java.sh ${jhome}; \\
496+
microdnf remove -y binutils; \\
497+
microdnf clean all; \\
498+
EOI
499+
}
500+
501+
# Call the script to create the slim package for Ubi
502+
print_centos_slim_package() {
503+
cat >> "$1" <<-EOI
484504
export PATH="${jhome}/bin:\$PATH"; \\
485505
/usr/local/bin/slim-java.sh ${jhome}; \\
486506
EOI
@@ -661,9 +681,12 @@ RUN set -eux; \\
661681
case "\${ARCH}" in \\
662682
EOI
663683
print_java_install_pre "${file}" "${pkg}" "${bld}" "${btype}" "${osfamily}" "${os}"
664-
if [ "${btype}" == "slim" ]; then
684+
if [ "${btype}" == "slim" && ${os} == "ubi"]; then
665685
print_ubi_slim_package "$1"
666686
fi
687+
if [ "${btype}" == "slim" && ${os} == "ubi-minimal"]; then
688+
print_ubi-minimal_slim_package "$1"
689+
fi
667690
print_java_install_post "$1"
668691
}
669692

@@ -687,7 +710,7 @@ RUN set -eux; \\
687710
EOI
688711
print_java_install_pre "${file}" "${pkg}" "${bld}" "${btype}" "${osfamily}" "${os}"
689712
if [ "${btype}" == "slim" ]; then
690-
print_ubi_slim_package "$1"
713+
print_centos_slim_package "$1"
691714
fi
692715
print_java_install_post "$1"
693716
}

0 commit comments

Comments
 (0)