Fix UI/UX issues on macOS:

- Remove horizontal scrollbar from Connection Settings dialog
- Fix title of Connection Settings dialog
- Hide External formatters section in Global Settings dialog
- Fix giant buttons in database inline menu
- Fix RedisInsight#4698

Author: uglide

src/qml/ConnectionSettignsDialog.qml

@@ -9,7 +9,7 @@ import "./common/platformutils.js" as PlatformUtils
 
 Dialog {
     id: root    
-    title: isNewConnection ? qsTranslate("RDM","New Connection Settings") : qsTranslate("RDM","Edit Connection Settings") + settings.name
+    title: isNewConnection ? qsTranslate("RDM","New Connection Settings") : qsTranslate("RDM","Edit Connection Settings") + " " + settings.name
 
     modality: Qt.ApplicationModal
 
@@ -139,11 +139,11 @@ Dialog {
 
                     ScrollView {
                         id: mainSettingsScrollView
-                        width: settingsTabs.width - 20
+                        width:  settingsTabs.width - 20
                         height: settingsTabs.height
 
                         ColumnLayout {                                                        
-                            width: mainSettingsScrollView.width
+                            width: PlatformUtils.isOSX()? mainSettingsScrollView.width - 20 : mainSettingsScrollView.width
                             height: children.height
 
                             SettingsGroupTitle { text: qsTranslate("RDM","Main Settings") }

src/qml/GlobalSettings.qml

@@ -17,7 +17,7 @@ Dialog {
     contentItem: Rectangle {
         id: dialogRoot
         implicitWidth: 800
-        implicitHeight: PlatformUtils.isOSX()? 680 : 600
+        implicitHeight: PlatformUtils.isOSX()? 500 : 600
 
         border.color: "#eeeeee"
         border.width: 1
@@ -149,16 +149,19 @@ Dialog {
                     }
 
                     SettingsGroupTitle {
-                        text: qsTranslate("RDM","Custom Value View Formatters")
+                        visible: !PlatformUtils.isOSX()
+                        text: qsTranslate("RDM","External Value View Formatters")
                     }
 
                     Text {
+                        visible: !PlatformUtils.isOSX()
                         text: qsTranslate("RDM","Formatters path: %0").arg(formattersManager.formattersPath())
                         font.pixelSize: 12
                         color: "grey"
                     }
 
                     TableView {
+                        visible: !PlatformUtils.isOSX()
                         Layout.fillWidth: true
                         Layout.fillHeight: true
                         verticalScrollBarPolicy: Qt.ScrollBarAlwaysOn

src/qml/app.qml

@@ -272,7 +272,7 @@ ApplicationWindow {
             BetterTabView {
                 id: bottomTabView
                 Layout.fillWidth: true
-                Layout.minimumHeight: PlatformUtils.isOSXRetina()? 15 : 30
+                Layout.minimumHeight: PlatformUtils.isOSXRetina(Screen)? 15 : 30
 
                 tabPosition: Qt.BottomEdge
 

src/qml/common/FilePathInput.qml

@@ -2,6 +2,8 @@ import QtQuick 2.3
 import QtQuick.Layouts 1.1
 import QtQuick.Controls 1.2
 import QtQuick.Dialogs 1.2
+import "./platformutils.js" as PlatformUtils
+
 
 RowLayout {
     id: root
@@ -14,11 +16,12 @@ RowLayout {
 
     TextField {
         id: textField
+        readOnly: PlatformUtils.isOSX()
         Layout.fillWidth: true
     }
 
     Button {
-        text: "..."
+        text: qsTranslate("RDM","Select File")
         onClicked: fileDialog.open()
     }
 

src/qml/connections-tree/menu/database.qml

@@ -4,6 +4,7 @@ import QtQuick.Controls 1.4
 import QtQuick.Window 2.2
 import "./../../common/platformutils.js" as PlatformUtils
 import "."
+import "./../../common/"
 
 RowLayout {
     id: root
@@ -160,7 +161,7 @@ RowLayout {
             }
         }
 
-        ToolButton {
+        ImageButton {
             id: filterOk
             iconSource: "qrc:/images/ok.svg"
             objectName: "rdm_inline_menu_button_apply_filter"
@@ -176,14 +177,20 @@ RowLayout {
             }
         }
 
-        ToolButton {
+        ImageButton {
             id: filterHelp
+
+            imgWidth: PlatformUtils.isOSXRetina(Screen)? 20 : 25
+            imgHeight: PlatformUtils.isOSXRetina(Screen)? 20 : 25
             iconSource: "qrc:/images/help.svg"
             onClicked: Qt.openUrlExternally("http://docs.redisdesktop.com/en/latest/features/#search-in-connection-tree")
         }
 
-        ToolButton {
+        ImageButton {
             id: filterCancel
+
+            imgWidth: PlatformUtils.isOSXRetina(Screen)? 20 : 25
+            imgHeight: PlatformUtils.isOSXRetina(Screen)? 20 : 25
             iconSource: "qrc:/images/clear.svg"
             objectName: "rdm_inline_menu_button_reset_filter"