Creating method to set error in task in lock problem

Author: otherpirate

dbaas/notification/models.py

@@ -159,3 +159,11 @@ def is_running(self):
     @property
     def is_status_error(self):
         return self.task_status == self.STATUS_ERROR
+
+    def error_in_lock(self, database):
+        self.add_detail("FAILED!")
+        self.add_detail("Database {} is not allocated for this task.".format(
+            database.name
+        ))
+        self.task_status = self.STATUS_ERROR
+        self.save()

dbaas/notification/tasks.py

@@ -627,10 +627,7 @@ def database_disk_resize(self, database, disk_offering, task_history, user):
     AuditRequest.new_request("database_disk_resize", user, "localhost")
 
     if not database.pin_task(task_history):
-        task_history.update_details("FAILED!", persist=True)
-        task_history.add_detail(
-            "Database {} is not allocated for this task.".format(db.name)
-        )
+        task_history.error_in_lock(database)
         return False
 
     databaseinfra = database.databaseinfra

dbaas/workflow/workflow.py

@@ -39,12 +39,7 @@ def _lock_databases(params, task):
     databases_pinned = []
     for database in databases:
         if not database.pin_task(task):
-            task.update_details("FAILED!", persist=True)
-            task.add_detail(
-                "Database {} is not allocated for this task.".format(
-                    database.name
-                )
-            )
+            task.error_in_lock(database)
             for database in databases_pinned:
                 database.unpin_task()
             return False
@@ -267,12 +262,7 @@ def steps_for_instances(
     for database in databases:
         databases_locked = []
         if not database.update_task(task):
-            task.update_details("FAILED!", persist=True)
-            task.add_detail(
-                "Database {} is not allocated for this task.".format(
-                    database.name
-                )
-            )
+            task.error_in_lock(database)
 
             if since_step == 0:
                 for database in databases_locked: