Probably fixed ignoring cache for blobs and arraybuffers

Author: lisathesecond

src/index.js

@@ -69,6 +69,7 @@ function setupCache (config = {}) {
     if (!isFunction(next)) return next
 
     // Nothing in cache so we execute the default adapter or any given adapter
+    // Will throw if the request has a status different than 2xx
     res = await config.adapter(req)
 
     // Process response to store in cache

src/response.js

@@ -2,15 +2,10 @@ import limit from './limit'
 import { write } from './cache'
 
 async function response (config, req, res) {
-  const type = res.status / 100 | 0
-
-  // only cache 2xx response
-  if (type !== 2) {
-    return res
-  }
+  const { request = {} } = res
 
   // exclude binary response from cache
-  if (['arraybuffer', 'blob'].indexOf(res.responseType) > -1) {
+  if (['arraybuffer', 'blob'].indexOf(request.responseType) > -1) {
     return res
   }
 

test/spec/index.spec.js

@@ -43,6 +43,20 @@ describe('Integration', () => {
     assert.ok(response.request.fromCache)
   })
 
+  it('Should not cache requests with a status not in the 2xx range', async () => {
+    await api.cache.clear()
+
+    try {
+      await api({ url: 'https://httpbin.org/status/404' })
+    } catch (err) {
+      assert.equal(err.response.status, 404)
+
+      const length = await api.cache.length()
+
+      assert.equal(length, 0)
+    }
+  })
+
   it('Should bust cache when sending something else than a GET request', async () => {
     await api.cache.clear()