Skip to content

Commit d16545b

Browse files
committed
disabled page transitions, as the feature is totally borken (animation
timing issue + combined visual effects on iframe content and parent/ancestor HTML containers)
1 parent 81c154b commit d16545b

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

readium-js

src/templates/settings-dialog.html

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -130,9 +130,10 @@ <h5 id="setting-header-scroll-legend" class="setting-header">{{strings.i18n_scro
130130

131131
</div>
132132

133-
<h5 hiddenx="hidden" id="setting-header-pageTransition-legend" class="setting-header">{{strings.i18n_page_transition}}</h5>
133+
<!-- Page transitions are seriously broken (see readium-shared-js one_page_view.js disablePageTransitions boolean), so we hide the UI config options -->
134+
<h5 style="display:none;" hiddenx="hidden" id="setting-header-pageTransition-legend" class="setting-header">{{strings.i18n_page_transition}}</h5>
134135

135-
<div hiddenx="hidden" role="radiogroup" class="row" style="width:100%;text-align:center;" aria-labelledby="setting-header-pageTransition-legend">
136+
<div style="display:none; width:100%;text-align:center;" hiddenx="hidden" role="radiogroup" class="row" aria-labelledby="setting-header-pageTransition-legend">
136137

137138
<div role="radio" id="pageTransition-none-option" style="vertical-align:middle;width:15%;display:inline-block;position:relative;">
138139
<input style="" name="pageTransition" value="single" type="radio" id="pageTransition-none-radio"/>

0 commit comments

Comments
 (0)