-
Notifications
You must be signed in to change notification settings - Fork 191
Getters for JsonPatch* class attributes #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I can't speak to @fge's rationale for it. fge hasn't really been responding here. I'm not sure if there is a new maintainer. If you made a pull request, I could find some time to setup a build on crate-metadata/json-patch and publish a build of it to maven central. |
Time for a fork? |
I got the builds setup and am happy to accept pull requests at the crate-metadata/json-patch fork and build them to maven central @ net.box.json-patch. I'm in communication with @fge about getting access to his maven central repo so that I can push builds there but haven't heard anything yet. |
Can you do an actual build and release so I can depend on it? |
1 similar comment
Can you do an actual build and release so I can depend on it? |
yeah I can do one at net.box#json-patch instead of com.github.fge#json-patch. We have to get the change merged over at the fork first though. |
HI @chb0github @huggsboson , is this still required? Happy to consider creating a branch here for that - it sounds logical. |
@daveclayton Well, anymore discussion about a a new release should be done on the forked repo as an issue and not here. |
did anything happen to this feature request? |
The project is dead and has been forked
…On Mon, Jun 17, 2019, 01:56 Jens Kristian Villadsen < ***@***.***> wrote:
did anything happen to this feature request?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#33?email_source=notifications&email_token=AALIRUDHWGQMBDFJ4GGSSADP25GVDA5CNFSM4BMWUR3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2QBEQ#issuecomment-502595730>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AALIRUBDER7PLZOJZUJQU5DP25GVDANCNFSM4BMWUR3A>
.
|
Was there a particular design reason no getters were provided in the JsonPatch classes? I'm deserializing json over the wire into instances of these classes and attempting to provide for a JSR303 validation implementation allowing me to limit patch operations, without public methods to access class attributes (i.e. path), it's seemingly impossible. I'd hate to convert to something that I can access the attributes, it seems cumbersome.
Thoughts?
The text was updated successfully, but these errors were encountered: