Skip to content

Getters for JsonPatch* class attributes #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ssteveli opened this issue Aug 4, 2015 · 10 comments
Open

Getters for JsonPatch* class attributes #33

ssteveli opened this issue Aug 4, 2015 · 10 comments

Comments

@ssteveli
Copy link

ssteveli commented Aug 4, 2015

Was there a particular design reason no getters were provided in the JsonPatch classes? I'm deserializing json over the wire into instances of these classes and attempting to provide for a JSR303 validation implementation allowing me to limit patch operations, without public methods to access class attributes (i.e. path), it's seemingly impossible. I'd hate to convert to something that I can access the attributes, it seems cumbersome.

Thoughts?

@huggsboson
Copy link
Member

huggsboson commented Aug 4, 2015

I can't speak to @fge's rationale for it. fge hasn't really been responding here. I'm not sure if there is a new maintainer. If you made a pull request, I could find some time to setup a build on crate-metadata/json-patch and publish a build of it to maven central.

@chb0github
Copy link

Time for a fork?

@huggsboson
Copy link
Member

huggsboson commented Jun 21, 2016

I got the builds setup and am happy to accept pull requests at the crate-metadata/json-patch fork and build them to maven central @ net.box.json-patch. I'm in communication with @fge about getting access to his maven central repo so that I can push builds there but haven't heard anything yet.

@chb0github
Copy link

Can you do an actual build and release so I can depend on it?

1 similar comment
@chb0github
Copy link

Can you do an actual build and release so I can depend on it?

@huggsboson
Copy link
Member

huggsboson commented Jun 29, 2016

yeah I can do one at net.box#json-patch instead of com.github.fge#json-patch. We have to get the change merged over at the fork first though.

@daveclayton
Copy link
Contributor

daveclayton commented Jul 7, 2016

HI @chb0github @huggsboson , is this still required?

Happy to consider creating a branch here for that - it sounds logical.

@chb0github
Copy link

@daveclayton Well, anymore discussion about a a new release should be done on the forked repo as an issue and not here.

@jvitrifork
Copy link
Contributor

did anything happen to this feature request?

@chb0github
Copy link

chb0github commented Jun 17, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants