Skip to content

Integrate crate-metadata fork #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
facboy opened this issue Sep 4, 2019 · 6 comments
Open

Integrate crate-metadata fork #58

facboy opened this issue Sep 4, 2019 · 6 comments

Comments

@facboy
Copy link

facboy commented Sep 4, 2019

Are there any plans to integrate the changes in https://github.com/crate-metadata/json-patch?

@huggsboson
Copy link
Member

I merged the json-schema ones. Happy to merge a PR that copies them over.

@huggsboson
Copy link
Member

The only wrinkle is I'm not sure if we diverged from the spec at all with those patches.

@facboy
Copy link
Author

facboy commented Sep 5, 2019

hmm...how can you tell?

@huggsboson
Copy link
Member

I probably just have to look through. Was there any particular patchset you wanted pulled forward?

@facboy
Copy link
Author

facboy commented Sep 6, 2019

hmm...at the moment we are dependent on some of the introduced operations, though whether we actually use them in practice, i'm not sure.

@facboy
Copy link
Author

facboy commented Sep 6, 2019

after some tidy up i think we can return to using this library without the crate-metadata changes - now that this is being maintained i suspect it's better to stay closer to the RFC standard without the extra operations. were there any bug-fixes or improvements on the fork that aren't related to the extra operations?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants