fixes senecajs#711

Author: rjrodger

lib/outward.js

@@ -107,6 +107,12 @@ function outward_res_object(ctxt, data) {
       !!res.force$
     )
 
+  // Responding with an Error as data is not allowed.
+  // https://github.com/senecajs/seneca/issues/711
+  if(data.out instanceof Error) {
+    not_object = true
+  }
+  
   var not_legacy = !(
     msg.cmd === 'generate_id' ||
     msg.note === true ||

test/error.test.js

@@ -21,6 +21,7 @@ var arrayify = Function.prototype.apply.bind(Array.prototype.slice)
 var make_test_transport = TransportStubs.make_test_transport
 
 describe('error', function() {
+  it('response_is_error', response_is_error)
   it('action_callback', action_callback)
   it('plugin_load', plugin_load)
 
@@ -45,6 +46,28 @@ describe('error', function() {
 
   it('legacy_fail', legacy_fail)
 
+
+  function response_is_error(fin) {
+    var si = Seneca({ log: 'silent' })
+
+    si.add('a:1', function(msg, reply) {
+      var foo = new Error('foo')
+      foo.a = 1
+      reply(null, foo)
+    })
+
+    si.error(function(err){
+      expect(err.code).equal('result_not_objarr')
+      fin()
+    })
+
+    si.act('a:1', function(err, out) {
+      expect(out).not.exist()
+      expect(err.code).equal('result_not_objarr')
+    })
+  }
+
+
   function action_callback(fin) {
     var si = Seneca({ log: 'silent' })