feat(EnumType) raise UnresolvedValueError for unknown values

Author: rmosolgo

lib/graphql/enum_type.rb

@@ -118,7 +118,7 @@ def coerce_result(value, warden = nil)
       if enum_value
         enum_value.name
       else
-        raise("Can't resolve enum #{name} for #{value}")
+        raise(UnresolvedValueError, "Can't resolve enum #{name} for #{value}")
       end
     end
 
@@ -135,5 +135,8 @@ class EnumValue
 
       lazy_defined_attr_accessor :name, :description, :deprecation_reason, :value
     end
+
+    class UnresolvedValueError < GraphQL::Error
+    end
   end
 end

spec/graphql/enum_type_spec.rb

@@ -18,14 +18,14 @@
   end
 
   it "raises when a result value can't be coerced" do
-    assert_raises {
+    assert_raises(GraphQL::EnumType::UnresolvedValueError) {
       enum.coerce_result(:nonsense)
     }
   end
 
   describe "resolving with a warden" do
     module ExampleWarden
-      def enum_values(enum_type)
+      def self.enum_values(enum_type)
         []
       end
     end
@@ -34,7 +34,7 @@ def enum_values(enum_type)
       # OK
       assert_equal("YAK", enum.coerce_result("YAK"))
       # NOT OK
-      assert_raises {
+      assert_raises(GraphQL::EnumType::UnresolvedValueError) {
         enum.coerce_result("YAK", ExampleWarden)
       }
     end

spec/graphql/schema/mask_spec.rb

@@ -430,7 +430,7 @@ def error_messages(query_result)
         unit(name: "Uvular Trill") { ... on Phoneme { manner } }
       }
       |
-      assert_raises(RuntimeError) {
+      assert_raises(GraphQL::EnumType::UnresolvedValueError) {
         MaskHelpers.query_with_mask(query_string, mask)
       }
     end