Skip to content

Commit 4308482

Browse files
uniqueiniquitymhegazy
authored andcommitted
Increase maximum depth of outlining span search (microsoft#18704)
* Increase max depth of outlining spans to 120 * Update tests * Update tests to demonstrate limit * Set limit to 40 and update tests
1 parent 530e107 commit 4308482

File tree

4 files changed

+40
-79
lines changed

4 files changed

+40
-79
lines changed

src/services/outliningElementsCollector.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
/* @internal */
22
namespace ts.OutliningElementsCollector {
33
const collapseText = "...";
4-
const maxDepth = 20;
4+
const maxDepth = 40;
55
const defaultLabel = "#region";
66
const regionMatch = new RegExp("^\\s*//\\s*#(end)?region(?:\\s+(.*))?$");
77

tests/cases/fourslash/getOutliningSpans.ts

Lines changed: 13 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -79,32 +79,19 @@
7979
//// }|]
8080
////}|]
8181
//////outline with deep nesting
82-
////module m1[|{
83-
//// module m2[| {
84-
//// module m3[| {
85-
//// module m4[| {
86-
//// module m5[| {
87-
//// module m6[| {
88-
//// module m7[| {
89-
//// module m8[| {
90-
//// module m9[| {
91-
//// module m10[| {
92-
//// module m11 {
93-
//// module m12 {
94-
//// export interface IFoo {
95-
//// }
96-
//// }
97-
//// }
98-
//// }|]
99-
//// }|]
100-
//// }|]
101-
//// }|]
102-
//// }|]
103-
//// }|]
104-
//// }|]
105-
//// }|]
106-
//// }|]
107-
////}|]
82+
////var nest =[| [[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[
83+
//// [|[
84+
//// [
85+
//// [
86+
//// [
87+
//// [
88+
//// 1,2,3
89+
//// ]
90+
//// ]
91+
//// ]
92+
//// ]
93+
//// ]|]
94+
////]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|];
10895
////
10996
//////outline after a deeply nested node
11097
////class AfterNestedNodes[| {

tests/cases/fourslash/shims-pp/getOutliningSpans.ts

Lines changed: 13 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -79,32 +79,19 @@
7979
//// }|]
8080
////}|]
8181
//////outline with deep nesting
82-
////module m1[|{
83-
//// module m2[| {
84-
//// module m3[| {
85-
//// module m4[| {
86-
//// module m5[| {
87-
//// module m6[| {
88-
//// module m7[| {
89-
//// module m8[| {
90-
//// module m9[| {
91-
//// module m10[| {
92-
//// module m11 {
93-
//// module m12 {
94-
//// export interface IFoo {
95-
//// }
96-
//// }
97-
//// }
98-
//// }|]
99-
//// }|]
100-
//// }|]
101-
//// }|]
102-
//// }|]
103-
//// }|]
104-
//// }|]
105-
//// }|]
106-
//// }|]
107-
////}|]
82+
////var nest =[| [[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[
83+
//// [|[
84+
//// [
85+
//// [
86+
//// [
87+
//// [
88+
//// 1,2,3
89+
//// ]
90+
//// ]
91+
//// ]
92+
//// ]
93+
//// ]|]
94+
////]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|];
10895
////
10996
//////outline after a deeply nested node
11097
////class AfterNestedNodes[| {

tests/cases/fourslash/shims/getOutliningSpans.ts

Lines changed: 13 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -79,32 +79,19 @@
7979
//// }|]
8080
////}|]
8181
//////outline with deep nesting
82-
////module m1[|{
83-
//// module m2[| {
84-
//// module m3[| {
85-
//// module m4[| {
86-
//// module m5[| {
87-
//// module m6[| {
88-
//// module m7[| {
89-
//// module m8[| {
90-
//// module m9[| {
91-
//// module m10[| {
92-
//// module m11 {
93-
//// module m12 {
94-
//// export interface IFoo {
95-
//// }
96-
//// }
97-
//// }
98-
//// }|]
99-
//// }|]
100-
//// }|]
101-
//// }|]
102-
//// }|]
103-
//// }|]
104-
//// }|]
105-
//// }|]
106-
//// }|]
107-
////}|]
82+
////var nest =[| [[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[[|[
83+
//// [|[
84+
//// [
85+
//// [
86+
//// [
87+
//// [
88+
//// 1,2,3
89+
//// ]
90+
//// ]
91+
//// ]
92+
//// ]
93+
//// ]|]
94+
////]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|]]|];
10895
////
10996
//////outline after a deeply nested node
11097
////class AfterNestedNodes[| {

0 commit comments

Comments
 (0)