Proposed fix for pytest-docker-compose#32, simply checks for not None on port_configs

Author: RmStorm

README.rst

@@ -38,13 +38,12 @@ For performance reasons, the plugin is not enabled by default, so you must activ
 
 See `Installing and Using Plugins`_ for more information.
 
-To interact with Docker containers in your tests, use the following fixtures:
+To interact with Docker containers in your tests, use the following fixtures, these fixtures tell docker-compose to start all the services and then they fetch the associated container:
 
 ``function_scoped_container_getter``
     An object that fetches containers of the Docker ``compose.container.Container`` objects running during the test. The containers are fetched using ``function_scoped_container_getter.get('service_name')`` These containers each have an extra attribute called ``network_info`` added to them. This attribute has a list of ``pytest_docker_compose.NetworkInfo`` objects.
 
-    This information can be used to configure API clients and other objects that
-    will connect to services exposed by the Docker containers in your tests.
+    This information can be used to configure API clients and other objects that will connect to services exposed by the Docker containers in your tests.
 
     ``NetworkInfo`` is a container with the following fields:
 
@@ -93,7 +92,7 @@ Here's an example of a fixture called ``wait_for_api`` that waits for an HTTP se
 
     pytest_plugins = ["docker_compose"]
 
-
+    # Invoking this fixture: 'function_scoped_container_getter' starts all services
     @pytest.fixture(scope="function")
     def wait_for_api(function_scoped_container_getter):
         """Wait for the api from my_api_service to become responsive"""

setup.py

@@ -7,7 +7,7 @@
     name="pytest-docker-compose",
     description="Manages Docker containers during your integration tests",
     long_description=long_description,
-    version="3.1.0",
+    version="3.1.1",
     author="Roald Storm",
     author_email="[email protected]",
     url="https://github.com/pytest-docker-compose/pytest-docker-compose",

src/pytest_docker_compose/__init__.py

@@ -43,12 +43,16 @@ def create_network_info_for_container(container: Container):
     Generates :py:class:`NetworkInfo` instances corresponding to all available
     port bindings in a container
     """
+    # If ports are exposed by the docker container but not by docker expose
+    # container.ports looks like this:
+    # container.ports == {'4369/tcp': None,
+    # '5984/tcp': [{'HostIp': '0.0.0.0', 'HostPort': '32872'}],
+    # '9100/tcp': None}
     return [NetworkInfo(container_port=container_port,
                         hostname=port_config["HostIp"] or "localhost",
                         host_port=port_config["HostPort"],)
-            for container_port, port_configs in
-            container.ports.items()
-            for port_config in port_configs]
+            for container_port, port_configs in container.ports.items()
+            if port_configs is not None for port_config in port_configs]
 
 
 class DockerComposePlugin: