Skip to content

Commit 0815362

Browse files
committed
removed direct dependency on ruby-plsql in oracle_enhanced_procedures
1 parent e40dcfb commit 0815362

File tree

4 files changed

+4
-12
lines changed

4 files changed

+4
-12
lines changed

History.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
== 1.2.4 2010-02-23
22

3-
* Enhancements
4-
* added views, synonyms, packages, functions, procedures, indexes, triggers, types, primary, unique and foreign key contraints to structure dump
3+
* Enhancements:
4+
* added views, synonyms, packages, functions, procedures, indexes, triggers, types, primary, unique and foreign key constraints to structure dump
55
* added :temporary option for create_table to create temporary tables
66
* added :tablespace option for add_index
77
* support function based indexes in schema dump

lib/active_record/connection_adapters/oracle_enhanced_adapter.rb

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1621,15 +1621,7 @@ class CGI::Session::ActiveRecordStore::Session
16211621
end
16221622

16231623
# Load custom create, update, delete methods functionality
1624-
# rescue LoadError if ruby-plsql gem cannot be loaded
1625-
begin
1626-
require 'active_record/connection_adapters/oracle_enhanced_procedures'
1627-
rescue LoadError
1628-
if defined?(RAILS_DEFAULT_LOGGER)
1629-
RAILS_DEFAULT_LOGGER.info "INFO: ActiveRecord oracle_enhanced adapter could not load ruby-plsql gem. "+
1630-
"Custom create, update and delete methods will not be available."
1631-
end
1632-
end
1624+
require 'active_record/connection_adapters/oracle_enhanced_procedures'
16331625

16341626
# Load additional methods for composite_primary_keys support
16351627
require 'active_record/connection_adapters/oracle_enhanced_cpk'

lib/active_record/connection_adapters/oracle_enhanced_procedures.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
class_inheritable_accessor :custom_create_method, :custom_update_method, :custom_delete_method
55
end
66

7-
require 'ruby_plsql'
87
require 'active_support'
98

109
module ActiveRecord #:nodoc:

spec/spec_helper.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@
5252
end
5353

5454
require 'active_record/connection_adapters/oracle_enhanced_adapter'
55+
require 'ruby-plsql'
5556

5657
module LoggerSpecHelper
5758
def log_to(stream)

0 commit comments

Comments
 (0)