Skip to content

Commit 38ab7fb

Browse files
pavelfeldmanpavelfeldman
authored
fix(args): convert input arguments of Dict types to impl (microsoft#136)
1 parent 965df5b commit 38ab7fb

File tree

3 files changed

+119
-79
lines changed

3 files changed

+119
-79
lines changed

‎playwright/async_api.py

Lines changed: 54 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -405,7 +405,7 @@ async def fulfill(
405405
return mapping.from_maybe_impl(
406406
await self._impl_obj.fulfill(
407407
status=status,
408-
headers=headers,
408+
headers=mapping.to_impl(headers),
409409
body=body,
410410
path=path,
411411
contentType=contentType,
@@ -433,7 +433,7 @@ async def continue_(
433433
"""
434434
return mapping.from_maybe_impl(
435435
await self._impl_obj.continue_(
436-
method=method, headers=headers, postData=postData
436+
method=method, headers=mapping.to_impl(headers), postData=postData
437437
)
438438
)
439439

@@ -881,7 +881,9 @@ async def dispatchEvent(self, type: str, eventInit: typing.Dict = None) -> NoneT
881881
event-specific initialization properties.
882882
"""
883883
return mapping.from_maybe_impl(
884-
await self._impl_obj.dispatchEvent(type=type, eventInit=eventInit)
884+
await self._impl_obj.dispatchEvent(
885+
type=type, eventInit=mapping.to_impl(eventInit)
886+
)
885887
)
886888

887889
async def scrollIntoViewIfNeeded(self, timeout: int = None) -> NoneType:
@@ -926,7 +928,10 @@ async def hover(
926928
"""
927929
return mapping.from_maybe_impl(
928930
await self._impl_obj.hover(
929-
modifiers=modifiers, position=position, timeout=timeout, force=force
931+
modifiers=modifiers,
932+
position=mapping.to_impl(position),
933+
timeout=timeout,
934+
force=force,
930935
)
931936
)
932937

@@ -970,7 +975,7 @@ async def click(
970975
return mapping.from_maybe_impl(
971976
await self._impl_obj.click(
972977
modifiers=modifiers,
973-
position=position,
978+
position=mapping.to_impl(position),
974979
delay=delay,
975980
button=button,
976981
clickCount=clickCount,
@@ -1020,7 +1025,7 @@ async def dblclick(
10201025
return mapping.from_maybe_impl(
10211026
await self._impl_obj.dblclick(
10221027
modifiers=modifiers,
1023-
position=position,
1028+
position=mapping.to_impl(position),
10241029
delay=delay,
10251030
button=button,
10261031
timeout=timeout,
@@ -1873,7 +1878,10 @@ async def dispatchEvent(
18731878
"""
18741879
return mapping.from_maybe_impl(
18751880
await self._impl_obj.dispatchEvent(
1876-
selector=selector, type=type, eventInit=eventInit, timeout=timeout
1881+
selector=selector,
1882+
type=type,
1883+
eventInit=mapping.to_impl(eventInit),
1884+
timeout=timeout,
18771885
)
18781886
)
18791887

@@ -2099,7 +2107,7 @@ async def click(
20992107
await self._impl_obj.click(
21002108
selector=selector,
21012109
modifiers=modifiers,
2102-
position=position,
2110+
position=mapping.to_impl(position),
21032111
delay=delay,
21042112
button=button,
21052113
clickCount=clickCount,
@@ -2150,7 +2158,7 @@ async def dblclick(
21502158
await self._impl_obj.dblclick(
21512159
selector=selector,
21522160
modifiers=modifiers,
2153-
position=position,
2161+
position=mapping.to_impl(position),
21542162
delay=delay,
21552163
button=button,
21562164
timeout=timeout,
@@ -2322,7 +2330,7 @@ async def hover(
23222330
await self._impl_obj.hover(
23232331
selector=selector,
23242332
modifiers=modifiers,
2325-
position=position,
2333+
position=mapping.to_impl(position),
23262334
timeout=timeout,
23272335
force=force,
23282336
)
@@ -3201,7 +3209,10 @@ async def dispatchEvent(
32013209
"""
32023210
return mapping.from_maybe_impl(
32033211
await self._impl_obj.dispatchEvent(
3204-
selector=selector, type=type, eventInit=eventInit, timeout=timeout
3212+
selector=selector,
3213+
type=type,
3214+
eventInit=mapping.to_impl(eventInit),
3215+
timeout=timeout,
32053216
)
32063217
)
32073218

@@ -3467,7 +3478,7 @@ async def setExtraHTTPHeaders(self, headers: typing.Dict) -> NoneType:
34673478
An object containing additional HTTP headers to be sent with every request. All header values must be strings.
34683479
"""
34693480
return mapping.from_maybe_impl(
3470-
await self._impl_obj.setExtraHTTPHeaders(headers=headers)
3481+
await self._impl_obj.setExtraHTTPHeaders(headers=mapping.to_impl(headers))
34713482
)
34723483

34733484
async def content(self) -> str:
@@ -3954,7 +3965,7 @@ async def screenshot(
39543965
quality=quality,
39553966
omitBackground=omitBackground,
39563967
fullPage=fullPage,
3957-
clip=clip,
3968+
clip=mapping.to_impl(clip),
39583969
)
39593970
)
39603971

@@ -4045,7 +4056,7 @@ async def click(
40454056
await self._impl_obj.click(
40464057
selector=selector,
40474058
modifiers=modifiers,
4048-
position=position,
4059+
position=mapping.to_impl(position),
40494060
delay=delay,
40504061
button=button,
40514062
clickCount=clickCount,
@@ -4098,7 +4109,7 @@ async def dblclick(
40984109
await self._impl_obj.dblclick(
40994110
selector=selector,
41004111
modifiers=modifiers,
4101-
position=position,
4112+
position=mapping.to_impl(position),
41024113
delay=delay,
41034114
button=button,
41044115
timeout=timeout,
@@ -4273,7 +4284,7 @@ async def hover(
42734284
await self._impl_obj.hover(
42744285
selector=selector,
42754286
modifiers=modifiers,
4276-
position=position,
4287+
position=mapping.to_impl(position),
42774288
timeout=timeout,
42784289
force=force,
42794290
)
@@ -4661,7 +4672,7 @@ async def pdf(
46614672
width=width,
46624673
height=height,
46634674
preferCSSPageSize=preferCSSPageSize,
4664-
margin=margin,
4675+
margin=mapping.to_impl(margin),
46654676
path=path,
46664677
)
46674678
)
@@ -4868,7 +4879,9 @@ async def addCookies(self, cookies: typing.List[typing.Dict]) -> NoneType:
48684879
----------
48694880
cookies : typing.List[typing.Dict]
48704881
"""
4871-
return mapping.from_maybe_impl(await self._impl_obj.addCookies(cookies=cookies))
4882+
return mapping.from_maybe_impl(
4883+
await self._impl_obj.addCookies(cookies=mapping.to_impl(cookies))
4884+
)
48724885

48734886
async def clearCookies(self) -> NoneType:
48744887
"""BrowserContext.clearCookies
@@ -4933,7 +4946,9 @@ async def setGeolocation(self, geolocation: typing.Dict = None) -> NoneType:
49334946
geolocation : Optional[typing.Dict]
49344947
"""
49354948
return mapping.from_maybe_impl(
4936-
await self._impl_obj.setGeolocation(geolocation=geolocation)
4949+
await self._impl_obj.setGeolocation(
4950+
geolocation=mapping.to_impl(geolocation)
4951+
)
49374952
)
49384953

49394954
async def setExtraHTTPHeaders(self, headers: typing.Dict) -> NoneType:
@@ -4949,7 +4964,7 @@ async def setExtraHTTPHeaders(self, headers: typing.Dict) -> NoneType:
49494964
An object containing additional HTTP headers to be sent with every request. All header values must be strings.
49504965
"""
49514966
return mapping.from_maybe_impl(
4952-
await self._impl_obj.setExtraHTTPHeaders(headers=headers)
4967+
await self._impl_obj.setExtraHTTPHeaders(headers=mapping.to_impl(headers))
49534968
)
49544969

49554970
async def setOffline(self, offline: bool) -> NoneType:
@@ -5160,7 +5175,7 @@ async def send(self, method: str, params: typing.Dict = None) -> typing.Dict:
51605175
typing.Dict
51615176
"""
51625177
return mapping.from_maybe_impl(
5163-
await self._impl_obj.send(method=method, params=params)
5178+
await self._impl_obj.send(method=method, params=mapping.to_impl(params))
51645179
)
51655180

51665181
async def detach(self) -> NoneType:
@@ -5314,18 +5329,18 @@ async def newContext(
53145329
"""
53155330
return mapping.from_impl(
53165331
await self._impl_obj.newContext(
5317-
viewport=viewport,
5332+
viewport=mapping.to_impl(viewport),
53185333
ignoreHTTPSErrors=ignoreHTTPSErrors,
53195334
javaScriptEnabled=javaScriptEnabled,
53205335
bypassCSP=bypassCSP,
53215336
userAgent=userAgent,
53225337
locale=locale,
53235338
timezoneId=timezoneId,
5324-
geolocation=geolocation,
5339+
geolocation=mapping.to_impl(geolocation),
53255340
permissions=permissions,
5326-
extraHTTPHeaders=extraHTTPHeaders,
5341+
extraHTTPHeaders=mapping.to_impl(extraHTTPHeaders),
53275342
offline=offline,
5328-
httpCredentials=httpCredentials,
5343+
httpCredentials=mapping.to_impl(httpCredentials),
53295344
deviceScaleFactor=deviceScaleFactor,
53305345
isMobile=isMobile,
53315346
hasTouch=hasTouch,
@@ -5401,18 +5416,18 @@ async def newPage(
54015416
"""
54025417
return mapping.from_impl(
54035418
await self._impl_obj.newPage(
5404-
viewport=viewport,
5419+
viewport=mapping.to_impl(viewport),
54055420
ignoreHTTPSErrors=ignoreHTTPSErrors,
54065421
javaScriptEnabled=javaScriptEnabled,
54075422
bypassCSP=bypassCSP,
54085423
userAgent=userAgent,
54095424
locale=locale,
54105425
timezoneId=timezoneId,
5411-
geolocation=geolocation,
5426+
geolocation=mapping.to_impl(geolocation),
54125427
permissions=permissions,
5413-
extraHTTPHeaders=extraHTTPHeaders,
5428+
extraHTTPHeaders=mapping.to_impl(extraHTTPHeaders),
54145429
offline=offline,
5415-
httpCredentials=httpCredentials,
5430+
httpCredentials=mapping.to_impl(httpCredentials),
54165431
deviceScaleFactor=deviceScaleFactor,
54175432
isMobile=isMobile,
54185433
hasTouch=hasTouch,
@@ -5582,10 +5597,10 @@ async def launch(
55825597
handleSIGTERM=handleSIGTERM,
55835598
handleSIGHUP=handleSIGHUP,
55845599
timeout=timeout,
5585-
env=env,
5600+
env=mapping.to_impl(env),
55865601
headless=headless,
55875602
devtools=devtools,
5588-
proxy=proxy,
5603+
proxy=mapping.to_impl(proxy),
55895604
downloadsPath=downloadsPath,
55905605
slowMo=slowMo,
55915606
chromiumSandbox=chromiumSandbox,
@@ -5658,10 +5673,10 @@ async def launchServer(
56585673
handleSIGTERM=handleSIGTERM,
56595674
handleSIGHUP=handleSIGHUP,
56605675
timeout=timeout,
5661-
env=env,
5676+
env=mapping.to_impl(env),
56625677
headless=headless,
56635678
devtools=devtools,
5664-
proxy=proxy,
5679+
proxy=mapping.to_impl(proxy),
56655680
downloadsPath=downloadsPath,
56665681
port=port,
56675682
chromiumSandbox=chromiumSandbox,
@@ -5785,24 +5800,24 @@ async def launchPersistentContext(
57855800
handleSIGTERM=handleSIGTERM,
57865801
handleSIGHUP=handleSIGHUP,
57875802
timeout=timeout,
5788-
env=env,
5803+
env=mapping.to_impl(env),
57895804
headless=headless,
57905805
devtools=devtools,
5791-
proxy=proxy,
5806+
proxy=mapping.to_impl(proxy),
57925807
downloadsPath=downloadsPath,
57935808
slowMo=slowMo,
5794-
viewport=viewport,
5809+
viewport=mapping.to_impl(viewport),
57955810
ignoreHTTPSErrors=ignoreHTTPSErrors,
57965811
javaScriptEnabled=javaScriptEnabled,
57975812
bypassCSP=bypassCSP,
57985813
userAgent=userAgent,
57995814
locale=locale,
58005815
timezoneId=timezoneId,
5801-
geolocation=geolocation,
5816+
geolocation=mapping.to_impl(geolocation),
58025817
permissions=permissions,
5803-
extraHTTPHeaders=extraHTTPHeaders,
5818+
extraHTTPHeaders=mapping.to_impl(extraHTTPHeaders),
58045819
offline=offline,
5805-
httpCredentials=httpCredentials,
5820+
httpCredentials=mapping.to_impl(httpCredentials),
58065821
deviceScaleFactor=deviceScaleFactor,
58075822
isMobile=isMobile,
58085823
hasTouch=hasTouch,

0 commit comments

Comments
 (0)