Fix: Correctly render sections with href in sidebar (styleguidist#1346)

Closes styleguidist#1141

Author: eragon512

src/client/rsg-components/ComponentsList/ComponentsList.js

@@ -6,6 +6,7 @@ import getUrl from '../../utils/getUrl';
 function ComponentsList({ classes, items, useRouterLinks = false, useHashId, hashPath }) {
 	const mappedItems = items.map(item => ({
 		...item,
+		shouldOpenInNewTab: !!item.href,
 		href: item.href
 			? item.href
 			: getUrl({

src/client/rsg-components/ComponentsList/ComponentsListRenderer.js

@@ -47,21 +47,20 @@ export function ComponentsListRenderer({ classes, items }) {
 	const windowHash = window.location.pathname + getHash(window.location.hash);
 	return (
 		<ul className={classes.list}>
-			{items.map(({ heading, visibleName, href, content, external }) => {
+			{items.map(({ heading, visibleName, href, content, shouldOpenInNewTab }) => {
 				const isItemSelected = windowHash === href;
 				return (
 					<li
-						className={cx(
-							classes.item,
-							(!content || !content.props.items.length) && classes.isChild,
-							isItemSelected && classes.isSelected
-						)}
+						className={cx(classes.item, {
+							[classes.isChild]: (!content || !content.props.items.length) && !shouldOpenInNewTab,
+							[classes.isSelected]: isItemSelected,
+						})}
 						key={href}
 					>
 						<Link
 							className={cx(heading && classes.heading)}
 							href={href}
-							target={external ? '_blank' : undefined}
+							target={shouldOpenInNewTab ? '_blank' : undefined}
 						>
 							{visibleName}
 						</Link>

src/client/rsg-components/ComponentsList/__snapshots__/ComponentsList.spec.js.snap

@@ -8,11 +8,13 @@ exports[`if a custom href is provided, should use it instead of generating inter
       Object {
         "href": "http://example.com",
         "name": "External example",
+        "shouldOpenInNewTab": true,
         "visibleName": "External example",
       },
       Object {
         "href": "/#input",
         "name": "Input",
+        "shouldOpenInNewTab": false,
         "slug": "input",
         "visibleName": "Input",
       },
@@ -72,12 +74,14 @@ exports[`should set a parameter on link when useHashId is activated 1`] = `
       Object {
         "href": "/#/Components?id=button",
         "name": "Button",
+        "shouldOpenInNewTab": false,
         "slug": "button",
         "visibleName": "Button",
       },
       Object {
         "href": "/#/Components?id=input",
         "name": "Input",
+        "shouldOpenInNewTab": false,
         "slug": "input",
         "visibleName": "Input",
       },
@@ -94,11 +98,13 @@ exports[`should set a sub route on link when useHashId is deactivated 1`] = `
       Object {
         "href": "/#/Components/Button",
         "name": "Button",
+        "shouldOpenInNewTab": false,
         "slug": "button",
       },
       Object {
         "href": "/#/Components/Input",
         "name": "Input",
+        "shouldOpenInNewTab": false,
         "slug": "input",
       },
     ]
@@ -114,12 +120,14 @@ exports[`should set the correct href for items 1`] = `
       Object {
         "href": "/#button",
         "name": "Button",
+        "shouldOpenInNewTab": false,
         "slug": "button",
         "visibleName": "Button",
       },
       Object {
         "href": "/#input",
         "name": "Input",
+        "shouldOpenInNewTab": false,
         "slug": "input",
         "visibleName": "Input",
       },