Rename is_landing_page? to the Ruby convention

- Also added specs
- And removed references for it in the graphql layout,
  since it can just be defined as false

Author: Elle Meredith

app/controllers/pages_controller.rb

@@ -28,10 +28,10 @@ def beta?
   end
   helper_method :beta?
 
-  def is_landing_page?
-    @page && @page.is_landing_page?
+  def landing_page?
+    @page && @page.landing_page?
   end
-  helper_method :is_landing_page?
+  helper_method :landing_page?
 
   def layout_by_path
     if request.path.starts_with? "/docs/apis/graphql"

app/models/page.rb

@@ -88,7 +88,7 @@ def initialize(view, name)
     @name = name
   end
 
-  def is_landing_page?
+  def landing_page?
     LandingPages.all.include? @name
   end
 

app/views/layouts/application.html.erb

@@ -8,13 +8,13 @@
     <main id="main" role="main">
       <div class="Docs__page-container StandardWhiteContentPage">
         <div class="Docs__page-container__inner PageContainer">
-          <div class="Docs__article<%= is_landing_page? ? ' Docs__article--is-landing-page' : '' %>">
+          <div class="Docs__article<%= landing_page? ? ' Docs__article--is-landing-page' : '' %>">
             <div class="column1">
               <%= render "notification" %>
               <div class="TextContent">
                 <%= yield %>
               </div>
-              <%= render "footer", :embed_emojicom => !is_landing_page? %>
+              <%= render "footer", :embed_emojicom => !landing_page? %>
             </div>
             <div class="column2"></div>
           </div>

app/views/layouts/graphql.html.erb

@@ -8,13 +8,13 @@
     <main id="main" role="main">
       <div class="Docs__page-container StandardWhiteContentPage">
         <div class="Docs__page-container__inner PageContainer">
-          <div class="Docs__article<%= is_landing_page? ? ' Docs__article--is-landing-page' : '' %>">
+          <div class="Docs__article">
             <div class="column1">
               <%= render "notification" %>
               <div class="TextContent">
                 <%= yield %>
               </div>
-              <%= render "footer", :embed_emojicom => !is_landing_page? %>
+              <%= render "footer", :embed_emojicom => false %>
             </div>
             <div class="column2"></div>
           </div>

spec/models/page_spec.rb

@@ -20,4 +20,24 @@
       end
     end
   end
+
+  describe "#landing_page?" do
+    context "when page's path is defined in LandingPages" do
+      it "returns true" do
+        allow(LandingPages).to receive(:all).and_return(["integrations"])
+        page = Page.new(double, "integrations")
+
+        expect(page).to be_landing_page
+      end
+    end
+
+    context "when page's path is not defined in the LandingPages" do
+      it "returns false" do
+        allow(LandingPages).to receive(:all).and_return([])
+        page = Page.new(double, "apis/agent-api")
+
+        expect(page).not_to be_landing_page
+      end
+    end
+  end
 end