Skip to content

Commit ceb5c70

Browse files
committed
apply reorder-python-imports
1 parent 25270db commit ceb5c70

15 files changed

+83
-64
lines changed

examples/hello/hello.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
from datetime import datetime
2-
from flask import Flask, request, flash, url_for, redirect, \
3-
render_template
2+
3+
from flask import flash
4+
from flask import Flask
5+
from flask import redirect
6+
from flask import render_template
7+
from flask import request
8+
from flask import url_for
49
from flask_sqlalchemy import SQLAlchemy
510

611

src/flask_sqlalchemy/__init__.py

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,16 +7,22 @@
77
from time import perf_counter
88

99
import sqlalchemy
10-
from flask import _app_ctx_stack, abort, current_app, request
10+
from flask import _app_ctx_stack
11+
from flask import abort
12+
from flask import current_app
13+
from flask import request
1114
from flask.signals import Namespace
12-
from sqlalchemy import event, inspect, orm
15+
from sqlalchemy import event
16+
from sqlalchemy import inspect
17+
from sqlalchemy import orm
1318
from sqlalchemy.engine.url import make_url
14-
from sqlalchemy.ext.declarative import DeclarativeMeta, declarative_base
19+
from sqlalchemy.ext.declarative import declarative_base
20+
from sqlalchemy.ext.declarative import DeclarativeMeta
1521
from sqlalchemy.orm.exc import UnmappedClassError
1622
from sqlalchemy.orm.session import Session as SessionBase
1723

18-
from flask_sqlalchemy.model import Model
1924
from .model import DefaultMeta
25+
from .model import Model
2026

2127
__version__ = "3.0.0.dev"
2228

src/flask_sqlalchemy/model.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22

33
import sqlalchemy as sa
44
from sqlalchemy import inspect
5-
from sqlalchemy.ext.declarative import DeclarativeMeta, declared_attr
5+
from sqlalchemy.ext.declarative import DeclarativeMeta
6+
from sqlalchemy.ext.declarative import declared_attr
67
from sqlalchemy.schema import _get_table_key
78

89

tests/conftest.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
import flask
44
import pytest
55

6-
import flask_sqlalchemy as fsa
6+
from flask_sqlalchemy import SQLAlchemy
77

88

99
@pytest.fixture
@@ -16,7 +16,7 @@ def app(request):
1616

1717
@pytest.fixture
1818
def db(app):
19-
return fsa.SQLAlchemy(app)
19+
return SQLAlchemy(app)
2020

2121

2222
@pytest.fixture

tests/test_basic_app.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import flask
22

3-
import flask_sqlalchemy as fsa
3+
from flask_sqlalchemy import get_debug_queries
44

55

66
def test_basic_insert(app, db, Todo):
@@ -31,7 +31,7 @@ def test_query_recording(app, db, Todo):
3131
todo.done = True
3232
db.session.commit()
3333

34-
queries = fsa.get_debug_queries()
34+
queries = get_debug_queries()
3535
assert len(queries) == 2
3636

3737
query = queries[0]

tests/test_binds.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1-
import flask_sqlalchemy as fsa
2-
from sqlalchemy.ext.declarative import declared_attr
1+
from flask_sqlalchemy import get_state
2+
from flask_sqlalchemy import SQLAlchemy
3+
34

45
def test_basic_binds(app, db):
56
app.config['SQLALCHEMY_BINDS'] = {
@@ -83,13 +84,13 @@ class FooBoundModel(AbstractFooBoundModel):
8384

8485

8586
def test_connector_cache(app):
86-
db = fsa.SQLAlchemy()
87+
db = SQLAlchemy()
8788
db.init_app(app)
8889

8990
with app.app_context():
9091
db.get_engine()
9192

92-
connector = fsa.get_state(app).connectors[None]
93+
connector = get_state(app).connectors[None]
9394
assert connector._app is app
9495

9596

tests/test_config.py

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
11
from unittest import mock
2+
23
import pytest
4+
import sqlalchemy
35
from sqlalchemy.pool import NullPool
46

5-
import flask_sqlalchemy as fsa
7+
from flask_sqlalchemy import SQLAlchemy
68

79

810
@pytest.fixture
@@ -23,15 +25,15 @@ def test_default_error_without_uri_or_binds(self, app, recwarn):
2325
SQLALCHEMY_DATABASE_URI and SQLALCHEMY_BINDS are unset
2426
"""
2527

26-
fsa.SQLAlchemy(app)
28+
SQLAlchemy(app)
2729

2830
# Our pytest fixture for creating the app sets
2931
# SQLALCHEMY_DATABASE_URI, so undo that here so that we
3032
# can inspect what FSA does below:
3133
del app.config['SQLALCHEMY_DATABASE_URI']
3234

3335
with pytest.raises(RuntimeError) as exc_info:
34-
fsa.SQLAlchemy(app)
36+
SQLAlchemy(app)
3537

3638
expected = 'Either SQLALCHEMY_DATABASE_URI ' \
3739
'or SQLALCHEMY_BINDS needs to be set.'
@@ -45,7 +47,7 @@ def test_defaults_with_uri(self, app, recwarn):
4547
Our pytest fixture for creating the app sets SQLALCHEMY_DATABASE_URI
4648
"""
4749

48-
fsa.SQLAlchemy(app)
50+
SQLAlchemy(app)
4951

5052
# Expecting no warnings for default config with URI
5153
assert len(recwarn) == 0
@@ -60,51 +62,51 @@ def test_engine_creation_ok(self, app):
6062
""" create_engine() isn't called until needed. Let's make sure we can do that without
6163
errors or warnings.
6264
"""
63-
assert fsa.SQLAlchemy(app).get_engine()
65+
assert SQLAlchemy(app).get_engine()
6466

6567

66-
@mock.patch.object(fsa.sqlalchemy, 'create_engine', autospec=True, spec_set=True)
68+
@mock.patch.object(sqlalchemy, 'create_engine', autospec=True, spec_set=True)
6769
class TestCreateEngine:
6870
"""
6971
Tests for _EngineConnector and SQLAlchemy methods inolved in setting up
7072
the SQLAlchemy engine.
7173
"""
7274

7375
def test_engine_echo_default(self, m_create_engine, app_nr):
74-
fsa.SQLAlchemy(app_nr).get_engine()
76+
SQLAlchemy(app_nr).get_engine()
7577

7678
args, options = m_create_engine.call_args
7779
assert 'echo' not in options
7880

7981
def test_engine_echo_true(self, m_create_engine, app_nr):
8082
app_nr.config['SQLALCHEMY_ECHO'] = True
81-
fsa.SQLAlchemy(app_nr).get_engine()
83+
SQLAlchemy(app_nr).get_engine()
8284

8385
args, options = m_create_engine.call_args
8486
assert options['echo'] is True
8587

8688
def test_config_from_engine_options(self, m_create_engine, app_nr):
8789
app_nr.config['SQLALCHEMY_ENGINE_OPTIONS'] = {'foo': 'bar'}
88-
fsa.SQLAlchemy(app_nr).get_engine()
90+
SQLAlchemy(app_nr).get_engine()
8991

9092
args, options = m_create_engine.call_args
9193
assert options['foo'] == 'bar'
9294

9395
def test_config_from_init(self, m_create_engine, app_nr):
94-
fsa.SQLAlchemy(app_nr, engine_options={'bar': 'baz'}).get_engine()
96+
SQLAlchemy(app_nr, engine_options={'bar': 'baz'}).get_engine()
9597

9698
args, options = m_create_engine.call_args
9799
assert options['bar'] == 'baz'
98100

99101
def test_pool_class_default(self, m_create_engine, app_nr):
100-
fsa.SQLAlchemy(app_nr).get_engine()
102+
SQLAlchemy(app_nr).get_engine()
101103

102104
args, options = m_create_engine.call_args
103105
assert options['poolclass'].__name__ == 'StaticPool'
104106

105107
def test_pool_class_nullpool(self, m_create_engine, app_nr):
106108
engine_options = {'poolclass': NullPool}
107-
fsa.SQLAlchemy(app_nr, engine_options=engine_options).get_engine()
109+
SQLAlchemy(app_nr, engine_options=engine_options).get_engine()
108110

109111
args, options = m_create_engine.call_args
110112
assert options['poolclass'].__name__ == 'NullPool'

tests/test_meta_data.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
import sqlalchemy as sa
22

3-
import flask_sqlalchemy as fsa
3+
from flask_sqlalchemy import SQLAlchemy
44

55

66
def test_default_metadata(app):
7-
db = fsa.SQLAlchemy(app, metadata=None)
7+
db = SQLAlchemy(app, metadata=None)
88

99
class One(db.Model):
1010
id = db.Column(db.Integer, primary_key=True)
@@ -27,7 +27,7 @@ class CustomMetaData(sa.MetaData):
2727
pass
2828

2929
custom_metadata = CustomMetaData(schema="test_schema")
30-
db = fsa.SQLAlchemy(app, metadata=custom_metadata)
30+
db = SQLAlchemy(app, metadata=custom_metadata)
3131

3232
class One(db.Model):
3333
id = db.Column(db.Integer, primary_key=True)

tests/test_model_class.py

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,18 @@
11
import pytest
22
from sqlalchemy.exc import InvalidRequestError
3-
from sqlalchemy.ext.declarative import DeclarativeMeta, declarative_base
3+
from sqlalchemy.ext.declarative import declarative_base
4+
from sqlalchemy.ext.declarative import DeclarativeMeta
45

5-
import flask_sqlalchemy as fsa
6+
from flask_sqlalchemy import SQLAlchemy
67
from flask_sqlalchemy.model import BindMetaMixin
8+
from flask_sqlalchemy.model import Model
79

810

911
def test_custom_model_class():
10-
class CustomModelClass(fsa.Model):
12+
class CustomModelClass(Model):
1113
pass
1214

13-
db = fsa.SQLAlchemy(model_class=CustomModelClass)
15+
db = SQLAlchemy(model_class=CustomModelClass)
1416

1517
class SomeModel(db.Model):
1618
id = db.Column(db.Integer, primary_key=True)
@@ -22,8 +24,8 @@ def test_no_table_name():
2224
class NoNameMeta(BindMetaMixin, DeclarativeMeta):
2325
pass
2426

25-
db = fsa.SQLAlchemy(model_class=declarative_base(
26-
cls=fsa.Model, metaclass=NoNameMeta, name='Model'))
27+
db = SQLAlchemy(model_class=declarative_base(
28+
cls=Model, metaclass=NoNameMeta, name='Model'))
2729

2830
with pytest.raises(InvalidRequestError):
2931
class User(db.Model):

tests/test_pagination.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
import pytest
22
from werkzeug.exceptions import NotFound
33

4-
import flask_sqlalchemy as fsa
4+
from flask_sqlalchemy import Pagination
55

66

77
def test_basic_pagination():
8-
p = fsa.Pagination(None, 1, 20, 500, [])
8+
p = Pagination(None, 1, 20, 500, [])
99
assert p.page == 1
1010
assert not p.has_prev
1111
assert p.has_next
@@ -18,12 +18,12 @@ def test_basic_pagination():
1818

1919

2020
def test_pagination_pages_when_0_items_per_page():
21-
p = fsa.Pagination(None, 1, 0, 500, [])
21+
p = Pagination(None, 1, 0, 500, [])
2222
assert p.pages == 0
2323

2424

2525
def test_pagination_pages_when_total_is_none():
26-
p = fsa.Pagination(None, 1, 100, None, [])
26+
p = Pagination(None, 1, 100, None, [])
2727
assert p.pages == 0
2828

2929

tests/test_query_class.py

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
import flask_sqlalchemy as fsa
1+
from flask_sqlalchemy import BaseQuery
2+
from flask_sqlalchemy import SQLAlchemy
23

34

45
def test_default_query_class(db):
@@ -14,17 +15,17 @@ class Child(db.Model):
1415
c = Child()
1516
c.parent = p
1617

17-
assert type(Parent.query) == fsa.BaseQuery
18-
assert type(Child.query) == fsa.BaseQuery
19-
assert isinstance(p.children, fsa.BaseQuery)
20-
assert isinstance(db.session.query(Parent), fsa.BaseQuery)
18+
assert type(Parent.query) == BaseQuery
19+
assert type(Child.query) == BaseQuery
20+
assert isinstance(p.children, BaseQuery)
21+
assert isinstance(db.session.query(Parent), BaseQuery)
2122

2223

2324
def test_custom_query_class(app):
24-
class CustomQueryClass(fsa.BaseQuery):
25+
class CustomQueryClass(BaseQuery):
2526
pass
2627

27-
db = fsa.SQLAlchemy(app, query_class=CustomQueryClass)
28+
db = SQLAlchemy(app, query_class=CustomQueryClass)
2829

2930
class Parent(db.Model):
3031
id = db.Column(db.Integer, primary_key=True)
@@ -47,13 +48,13 @@ class Child(db.Model):
4748

4849

4950
def test_dont_override_model_default(app):
50-
class CustomQueryClass(fsa.BaseQuery):
51+
class CustomQueryClass(BaseQuery):
5152
pass
5253

53-
db = fsa.SQLAlchemy(app, query_class=CustomQueryClass)
54+
db = SQLAlchemy(app, query_class=CustomQueryClass)
5455

5556
class SomeModel(db.Model):
5657
id = db.Column(db.Integer, primary_key=True)
57-
query_class = fsa.BaseQuery
58+
query_class = BaseQuery
5859

59-
assert type(SomeModel.query) == fsa.BaseQuery
60+
assert type(SomeModel.query) == BaseQuery

tests/test_query_property.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
import pytest
22
from werkzeug.exceptions import NotFound
33

4-
import flask_sqlalchemy as fsa
4+
from flask_sqlalchemy import SQLAlchemy
55

66

77
def test_no_app_bound(app):
8-
db = fsa.SQLAlchemy()
8+
db = SQLAlchemy()
99
db.init_app(app)
1010

1111
class Foo(db.Model):

tests/test_sessions.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import sqlalchemy as sa
22
from sqlalchemy.orm import sessionmaker
33

4-
import flask_sqlalchemy as fsa
4+
from flask_sqlalchemy import SQLAlchemy
55

66

77
def test_default_session_scoping(app, db):
@@ -20,7 +20,7 @@ def test_session_scoping_changing(app):
2020
def scopefunc():
2121
return id(dict())
2222

23-
db = fsa.SQLAlchemy(app, session_options=dict(scopefunc=scopefunc))
23+
db = SQLAlchemy(app, session_options=dict(scopefunc=scopefunc))
2424

2525
class FOOBar(db.Model):
2626
id = db.Column(db.Integer, primary_key=True)

0 commit comments

Comments
 (0)