Skip to content

✨ Enhancement: Bowtie Cross Column Icon #1640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chauhan-varun opened this issue May 11, 2025 · 4 comments · May be fixed by #1641
Open

✨ Enhancement: Bowtie Cross Column Icon #1640

chauhan-varun opened this issue May 11, 2025 · 4 comments · May be fixed by #1641
Labels
✨ Enhancement Indicates that the issue suggests an improvement or new feature. Status: Triage This is the initial status for an issue that requires triage.

Comments

@chauhan-varun
Copy link

chauhan-varun commented May 11, 2025

Tools without Bowtie integration showed a cross (❌) icon, suggesting an error or problem.

Image

Description:-

These tools should show an information (ℹ️) icon, indicating that additional information is available.

Image

Image

The change has been tested to ensure proper rendering in both light and dark modes, and across different screen sizes.

How i fixed this:-

  1. Created a new SVG icon file:

    • Added /public/icons/icons8-info.svg with standard info icon design
    • Ensured the icon uses stroke="currentColor" to inherit theme colors
    • Matched styling attributes with other icons in the interface
  2. Updated the ToolingTable component:

    • Modified import statement from CancelIcon to InfoIcon
    • Updated the conditional rendering to use the info icon
    • Matched styling with the rest of the icons for visual consistency

Files Modified

  • /pages/tools/components/ToolingTable.tsx
  • Added /public/icons/icons8-info.svg

Are you working on this?

Yes

@chauhan-varun chauhan-varun added ✨ Enhancement Indicates that the issue suggests an improvement or new feature. Status: Triage This is the initial status for an issue that requires triage. labels May 11, 2025
@chauhan-varun chauhan-varun linked a pull request May 11, 2025 that will close this issue
1 task
@Utkarsh-123github
Copy link
Contributor

Hey @chauhan-varun , the cross icon isn't suggesting any sort of error/problem it is simply depicting that there isn't any Bowtie integration to this tool.
Also please refrain yourself raising any sort of PR before the issue gets accepted by JSON Schema maintainers.

@chauhan-varun
Copy link
Author

Hey @Utkarsh-123github ,
You're right the cross icon isn't showing an error — it's just indicating that there's no Bowtie integration. Still, the cross doesn’t quite look right, don’t you think? It might give the wrong impression. An info icon would probably fit better in this case.

@Utkarsh-123github
Copy link
Contributor

@chauhan-varun this is a design topic which can initially be discussed, so I think you should wait for the reply of team before raising any sort of PR as per contribution guidelines :)

@chauhan-varun
Copy link
Author

Hey @DhairyaMajmudar ,
Kindly take a look at this issue. I’ve already resolved it—please review the changes I made.
Thankyou 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Enhancement Indicates that the issue suggests an improvement or new feature. Status: Triage This is the initial status for an issue that requires triage.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants