Correct static validation of nested InputObjects

Author: chrisseto

lib/graphql/static_validation/rules/required_input_object_attributes_are_present.rb

@@ -12,7 +12,20 @@ def on_input_object(node, parent)
       private
 
       def get_parent_type(context, parent)
-        defn = context.field_definition
+        # If argument_definition is defined we're at nested object
+        # and need to refer to the containing input object type rather
+        # than the field_definition.
+        # h/t @rmosolgo
+        arg_defn = context.argument_definition
+
+        # Double checking that arg_defn is an input object as nested
+        # scalars, namely JSON, can make it to this branch
+        defn = if arg_defn && arg_defn.type.unwrap.kind.input_object?
+          arg_defn.type.unwrap
+        else
+          context.field_definition
+        end
+
         parent_type = context.warden.arguments(defn)
           .find{|f| f.name == parent_name(parent, defn) }
         parent_type ? parent_type.type.unwrap : nil

spec/graphql/static_validation/rules/required_input_object_attributes_are_present_spec.rb

@@ -12,6 +12,7 @@
       yakSource: searchDairy(product: [{source: COW, fatContent: 1.1}]) { __typename }
       badSource: searchDairy(product: [{source: 1.1}]) { __typename }
       missingSource: searchDairy(product: [{fatContent: 1.1}]) { __typename }
+      missingNestedRequiredInputObjectAttribute: searchDairy(product: [{fatContent: 1.2, order_by: {}}]) { __typename }
       listCoerce: cheese(id: 1) { similarCheese(source: YAK) { __typename } }
       missingInputField: searchDairy(product: [{source: YAK, wacky: 1}]) { __typename }
     }
@@ -42,16 +43,30 @@
         "inputObjectType"=>"DairyProductInput"
       }
     }
+    missing_order_by_direction_error = {
+      "message"=>"Argument 'direction' on InputObject 'ResourceOrderType' is required. Expected type String!",
+      "locations"=>[{"line"=>8, "column"=>100}],
+      "path"=>["query getCheese", "missingNestedRequiredInputObjectAttribute", "product", "order_by", "direction"],
+      "extensions"=>{
+        "code"=>"missingRequiredInputObjectAttribute",
+        "argumentName"=>"direction",
+        "argumentType"=>"String!",
+        "inputObjectType"=>"ResourceOrderType"
+      }
+    }
     it "finds undefined or missing-required arguments to fields and directives" do
       without_error_bubbling(schema) do
         assert_includes(errors, missing_source_error)
+        assert_includes(errors, missing_order_by_direction_error)
         refute_includes(errors, missing_required_field_error)
       end
     end
+    # focus
     it 'works with error bubbling enabled' do
       with_error_bubbling(schema) do
         assert_includes(errors, missing_required_field_error)
         assert_includes(errors, missing_source_error)
+        assert_includes(errors, missing_order_by_direction_error)
       end
     end
   end