tidy up

Author: karlfreeman

.gitignore

@@ -16,4 +16,4 @@ tmp
 # YARD artifacts
 .yardoc
 _yardoc
-doc/
+doc/

Gemfile

@@ -3,16 +3,16 @@ source "https://rubygems.org"
 gem "rake", ">= 1.2"
 gem "yard"
 
-gem "hiredis", "~> 0.4.5", :require => false
-gem "em-synchrony", :require => false
-
 # platforms :ruby_18 do
 # end
 # platforms :ruby, :mswin, :mingw do
 # end
 # platforms :jruby do
 # end
 
+gem "hiredis", "~> 0.4.5", :require => false
+gem "em-synchrony", :require => false
+
 group :development do
   gem "kramdown", ">= 0.14"
   gem "pry"
@@ -27,6 +27,7 @@ group :test do
   gem "timecop"
   gem "simplecov", :require => false
   gem "coveralls", :require => false
+  gem "cane"
 end
 
 gemspec

Rakefile

@@ -9,5 +9,19 @@ require "rspec/core/rake_task"
 desc "Run all examples"
 RSpec::Core::RakeTask.new(:spec)
 
+begin
+  require "cane/rake_task"
+  namespace :metric do
+    desc "Analyze for code quality"
+    Cane::RakeTask.new(:quality) do |cane|
+      cane.abc_max = 27
+      cane.no_doc = true
+      cane.style_measure = 200
+    end
+  end
+rescue LoadError
+  warn "Cane is not available, metric:quality task not provided."
+end
+
 task :default => :spec
 task :test => :spec

spec/unit/client_spec.rb

@@ -81,11 +81,13 @@
                   connection.flushdb
                 end
 
-                expect { client.push(:class => "MyWorker", :args => args) }.to change { client.connection_pool do |connection| connection.llen("queue:default"); end }.from(0).to(args.length)
+                expect { client.push(:class => "MyWorker", :args => args) }.to change {
+                  client.connection_pool do |connection| connection.llen("queue:default"); end
+                }.from(0).to(args.length)
 
                 raw_jobs = client.connection_pool do |connection| connection.lrange("queue:default", 0, args.length); end
                 raw_jobs.each do |job|
-                  job = MultiJson.decode(job, :symbolize_keys => true)  
+                  job = MultiJson.decode(job, :symbolize_keys => true)
                   expect(job).to have_key(:jid)
                 end
 
@@ -107,17 +109,19 @@
                       connection.flushdb
                     end
 
-                    expect { client.push(:class => "MyWorker", :args => args, :at => time) }.to change { client.connection_pool do |connection| connection.zcard("schedule"); end }.from(0).to(args.length)
+                    expect { client.push(:class => "MyWorker", :args => args, :at => time) }.to change {
+                      client.connection_pool do |connection| connection.zcard("schedule"); end
+                    }.from(0).to(args.length)
 
                     raw_jobs = client.connection_pool do |connection| connection.zrange("schedule", 0, args.length); end
                     raw_jobs.each do |job|
-                      job = MultiJson.decode(job, :symbolize_keys => true)  
+                      job = MultiJson.decode(job, :symbolize_keys => true)
                       expect(job).to have_key(:at)
                       expect(job[:at]).to be_within(1).of(Time.now.to_f)
                     end
 
                   end
-                  
+
                 end
 
               end

spec/unit/connection_spec.rb

@@ -38,7 +38,7 @@
           ENV[test_case[:name]] = "redis://#{test_case[:value]}:6379/0"
         end
         after do
-          ENV[test_case[:name]] = nil  
+          ENV[test_case[:name]] = nil
         end
         its(:host) { should eq test_case[:value] }
       end