Skip to content

Commit e055304

Browse files
committed
refactor: improve type safety in facets panel and store
1 parent b0ec408 commit e055304

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

keep-ui/features/filter/facets-panel.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,8 @@ export const FacetsPanel: React.FC<FacetsPanelProps> = ({
5454
onLoadFacetOptions = undefined,
5555
onReloadFacetOptions = undefined,
5656
}) => {
57-
const facetOptionsRef = useRef<any>(facetOptions);
57+
const facetOptionsRef =
58+
useRef<Record<string, FacetOptionDto[]>>(facetOptions);
5859
facetOptionsRef.current = facetOptions;
5960
const onCelChangeRef = useRef(onCelChange);
6061
onCelChangeRef.current = onCelChange;

keep-ui/features/filter/store/use-facets-config.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ export function useFacetsConfig(
88
const facetsConfigIdBased = useMemo(() => {
99
const result: FacetsConfig = {};
1010

11-
if (facets && Array.isArray(facets)) {
11+
if (facets) {
1212
facets.forEach((facet) => {
1313
const facetConfig = facetsConfig?.[facet.name];
1414
const sortCallback =

keep-ui/features/filter/store/use-store.tsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,10 @@ export function useNewFacetStore() {
99

1010
if (!storeRef.current) {
1111
storeRef.current = createFacetStore(); // New store per provider
12+
useFacetsLoadingStateHandler(storeRef.current);
13+
useQueriesHandler(storeRef.current);
1214
}
1315

14-
useFacetsLoadingStateHandler(storeRef.current);
15-
useQueriesHandler(storeRef.current);
16-
1716
return storeRef.current;
1817
}
1918

0 commit comments

Comments
 (0)