Fix Text Showing on hidden LoadingLayout

Christopher Banes · Christopher Banes · commit 8a71c60fe86b · 2013-01-08T15:44:44.000Z
diff --git a/library/src/com/handmark/pulltorefresh/library/internal/LoadingLayout.java b/library/src/com/handmark/pulltorefresh/library/internal/LoadingLayout.java
@@ -350,7 +350,12 @@ private void setSubHeaderText(CharSequence label) {
 				mSubHeaderText.setVisibility(View.GONE);
 			} else {
 				mSubHeaderText.setText(label);
-				mSubHeaderText.setVisibility(View.VISIBLE);
+
+				// Only set it to Visible if we're GONE, otherwise VISIBLE will
+				// be set soon
+				if (View.GONE == mSubHeaderText.getVisibility()) {
+					mSubHeaderText.setVisibility(View.VISIBLE);
+				}
 			}
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -350,7 +350,12 @@ private void setSubHeaderText(CharSequence label) {`
`350`	`350`	`mSubHeaderText.setVisibility(View.GONE);`
`351`	`351`	`} else {`
`352`	`352`	`mSubHeaderText.setText(label);`
`353`		`- mSubHeaderText.setVisibility(View.VISIBLE);`
	`353`	`+`
	`354`	`+ // Only set it to Visible if we're GONE, otherwise VISIBLE will`
	`355`	`+ // be set soon`
	`356`	`+ if (View.GONE == mSubHeaderText.getVisibility()) {`
	`357`	`+ mSubHeaderText.setVisibility(View.VISIBLE);`
	`358`	`+ }`
`354`	`359`	`}`
`355`	`360`	`}`
`356`	`361`	`}`