Version 2.0.0-dev.37.0

Merge commit 'a3c352a6e4db5ebb13f55a445ba7122525fc55db' into dev

Author: whesse

CHANGELOG.md

@@ -1,3 +1,36 @@
+## 2.0.0-dev.37.0
+
+### Tool Changes
+
+* dart2js
+
+  * The dart2js compiler now uses the common front-end by default. This is a
+    step towards supporting Dart 2.0. At this time dart2js has no semantic
+    changes: the Dart 2.0 strong-mode semantics are not enabled, so dart2js
+    continues to support the Dart 1 type system. This change however lets us
+    start supporting new syntactic features of Dart 2.0, like optional
+    new/const. With this change you may notice:
+
+    * small code differences (~1% code size): some code is generated slightly
+      different, this is expected because the internal representation of the
+      program has small differences between the old and new front end.
+
+    * source-maps changes: with the new front-end, dart2js also is using a new
+      mechanism to generate source-map files. We don't expect big differences
+      here either, the new source-maps try to encode more data for locations
+      that are commonly used during debugging.
+
+    * some missing errors: the CFE is not complete and may not report some
+      static errors that the old front-end did. This is temporary. If you run
+      the analyzer on all your project already, you may never notice those
+      missing error messages.
+
+    * as announced earlier, this is the first version of dart2js that no longer
+      supports `dart:mirrors`.
+
+    * this is the first version of dart2js that no longer supports
+      `--package-root`, which long ago was deprecated in favor of `--packages`.
+
 ## 2.0.0-dev.36.0
 
 ### Core library changes
@@ -76,6 +109,9 @@ the assignment to `y`.
   * `MapBase`: added `mapToString`.
   * `LinkedHashMap` no longer implements `HashMap`
   * `LinkedHashSet` no longer implements `HashSet`.
+  * Added `of` constructor to `Queue`, `ListQueue`,
+    `DoubleLinkedQueue`, `HashSet`, `LinkedHashSet`, `SplayTreeSet`,
+    `Map`, `HashMap`, `LinkedHashMap`, `SplayTreeMap`.
 
 * `dart:convert`
 
@@ -115,6 +151,7 @@ the assignment to `y`.
       * *Note*: if a class extends `IterableBase`, `ListBase`, `SetBase` or
         `MapBase` (or uses the corresponding mixins) from `dart:collection`, the
         new members are implemented automatically.
+      * Added `of` constructor to `List`, `Set`, `Map`.
   * Renamed `double.INFINITY`, `double.NEGATIVE_INFINITY`, `double.NAN`,
     `double.MAX_FINITE` and `double.MIN_POSITIVE`
     to `double.infinity`, `double.negativeInfinity`, `double.nan`,
@@ -346,6 +383,9 @@ the `PUB_ALLOW_PRERELEASE_SDK` environment variable to `false`.
 * Fix `pub global run` for packages activated from a local path that also have
   relative path dependencies ([issue 1751][pub#1751]).
 
+* `pub build` and `pub serve` support using the common front-end in the dart2js
+  transformer.
+
 [pub#1684]: https://github.com/dart-lang/pub/issues/1684
 [pub#1719]: https://github.com/dart-lang/pub/issues/1719
 [pub#1679]: https://github.com/dart-lang/pub/issues/1679

DEPS

@@ -50,7 +50,7 @@ vars = {
   "gperftools_revision": "@02eeed29df112728564a5dde6417fa4622b57a06",
 
   # Revisions of /third_party/* dependencies.
-  "args_tag": "@0.13.7",
+  "args_tag": "@1.4.1",
   "async_tag": "@2.0.6",
   "barback-0.13.0_rev": "@34853",
   "barback-0.14.0_rev": "@36398",
@@ -63,7 +63,7 @@ vars = {
   "charcode_tag": "@v1.1.1",
   "chrome_rev" : "@19997",
   "cli_util_tag" : "@0.1.2+1",
-  "collection_tag": "@6ff408a512df30559c1a18b37cfac9fc51a4ceef",
+  "collection_tag": "@1.14.6",
   "convert_tag": "@2.0.1",
   "crypto_tag" : "@2.0.2+1",
   "csslib_tag" : "@0.14.1",
@@ -83,7 +83,7 @@ vars = {
   # For more details, see https://github.com/dart-lang/sdk/issues/30164
   "dart_style_tag": "@1.0.10",  # Please see the note above before updating.
 
-  "dartdoc_tag" : "@v0.17.0",
+  "dartdoc_tag" : "@v0.17.1+1",
   "fixnum_tag": "@0.10.5",
   "func_rev": "@25eec48146a58967d75330075ab376b3838b18a8",
   "glob_tag": "@1.1.5",
@@ -92,16 +92,16 @@ vars = {
   "http_multi_server_tag" : "@2.0.4",
   "http_parser_tag" : "@3.1.1",
   "http_retry_tag": "@0.1.0",
-  "http_tag" : "@0.11.3+14",
+  "http_tag" : "@0.11.3+16",
   "http_throttle_tag" : "@1.0.1",
   "idl_parser_rev": "@7fbe68cab90c38147dee4f48c30ad0d496c17915",
   "intl_tag": "@0.15.2",
   "isolate_tag": "@1.1.0",
   "jinja2_rev": "@2222b31554f03e62600cd7e383376a7c187967a1",
   "json_rpc_2_tag": "@2.0.6",
-  "linter_tag": "@0.1.43",
+  "linter_tag": "@0.1.44",
   "logging_tag": "@0.11.3+1",
-  "markdown_tag": "@1.0.0",
+  "markdown_tag": "@1.1.1",
   "matcher_tag": "@0.12.1+4",
   "mime_tag": "@0.9.6",
   "mockito_tag": "@a92db054fba18bc2d605be7670aee74b7cadc00a",
@@ -115,21 +115,21 @@ vars = {
   "ply_rev": "@604b32590ffad5cbb82e4afef1d305512d06ae93",
   "pool_tag": "@1.3.4",
   "protobuf_tag": "@0.7.1",
-  "pub_rev": "@73ff0d3d9f80f60d41e3135ac44597d011abb4f3",
+  "pub_rev": "@d2755745e88b63448d0adfbf2d04af9050f45ed3",
   "pub_semver_tag": "@1.3.2",
   "quiver_tag": "@5aaa3f58c48608af5b027444d561270b53f15dbf",
   "resource_rev":"@af5a5bf65511943398146cf146e466e5f0b95cb9",
   "root_certificates_rev": "@16ef64be64c7dfdff2b9f4b910726e635ccc519e",
-  "shelf_static_rev": "@3558aa35a0d2f0f35868c3fd64b258e140db0122",
+  "shelf_static_rev": "@v0.2.7",
   "shelf_packages_handler_tag": "@1.0.3",
-  "shelf_tag": "@0.7.1",
+  "shelf_tag": "@0.7.2",
   "shelf_web_socket_tag": "@0.2.2",
   "source_map_stack_trace_tag": "@1.1.4",
   "source_maps-0.9.4_rev": "@38524",
   "source_maps_tag": "@0.10.4",
   "source_span_tag": "@1.4.0",
-  "stack_trace_tag": "@1.9.0",
-  "stream_channel_tag": "@1.6.2",
+  "stack_trace_tag": "@1.9.2",
+  "stream_channel_tag": "@1.6.4",
   "string_scanner_tag": "@1.0.2",
   "sunflower_rev": "@879b704933413414679396b129f5dfa96f7a0b1e",
   "test_descriptor_tag": "@1.0.3",

pkg/analysis_server/test/analysis/get_hover_test.dart

@@ -420,11 +420,11 @@ main() {
     expect(hover.containingLibraryPath, isNull);
     expect(hover.containingClassDescription, isNull);
     expect(hover.dartdoc, isNull);
-    expect(hover.elementDescription, 'dynamic vvv');
+    expect(hover.elementDescription, 'int vvv');
     expect(hover.elementKind, 'local variable');
     // types
-    expect(hover.staticType, 'dynamic');
-    expect(hover.propagatedType, 'int');
+    expect(hover.staticType, 'int');
+    expect(hover.propagatedType, null);
   }
 
   test_expression_variable_inMethod() async {
@@ -446,7 +446,7 @@ class A {
     expect(hover.elementKind, 'local variable');
     // types
     expect(hover.staticType, 'num');
-    expect(hover.propagatedType, 'int');
+    expect(hover.propagatedType, null);
     // no parameter
     expect(hover.parameter, isNull);
   }

pkg/analysis_server/test/analysis/notification_analysis_options_test.dart

@@ -59,13 +59,6 @@ main() {
     handleSuccessfulRequest(request);
   }
 
-  void setStrongMode(bool isSet) {
-    addOptionsFile('''
-analyzer:
-  strong-mode: $isSet
-''');
-  }
-
   @override
   void setUp() {
     generateSummaryFiles = true;
@@ -202,19 +195,23 @@ linter:
 
     await waitForTasksFinished();
 
-    // Verify strong-mode disabled.
-    verifyStrongMode(enabled: false);
+    // Verify that lints are disabled.
+    expect(analysisOptions.lint, false);
 
     // Clear errors.
     filesErrors[testFile] = [];
 
-    // Add options file with strong mode enabled.
-    setStrongMode(true);
+    // Add options file with a lint enabled.
+    addOptionsFile('''
+linter:
+  rules:
+    - camel_case_types
+''');
 
     await pumpEventQueue();
     await waitForTasksFinished();
 
-    verifyStrongMode(enabled: true);
+    verifyLintsEnabled(['camel_case_types']);
   }
 
   test_options_file_parse_error() async {
@@ -232,14 +229,18 @@ linter:
   }
 
   test_options_file_removed() async {
-    setStrongMode(true);
+    addOptionsFile('''
+linter:
+  rules:
+    - camel_case_types
+''');
 
     addTestFile(testSource);
     setAnalysisRoot();
 
     await waitForTasksFinished();
 
-    verifyStrongMode(enabled: true);
+    verifyLintsEnabled(['camel_case_types']);
 
     // Clear errors.
     filesErrors[testFile] = [];
@@ -249,46 +250,7 @@ linter:
     await pumpEventQueue();
     await waitForTasksFinished();
 
-    verifyStrongMode(enabled: false);
-  }
-
-  test_strong_mode_changed_off() async {
-    setStrongMode(true);
-
-    addTestFile(testSource);
-    setAnalysisRoot();
-
-    await waitForTasksFinished();
-
-    verifyStrongMode(enabled: true);
-
-    // Clear errors.
-    filesErrors[testFile] = [];
-
-    setStrongMode(false);
-
-    await pumpEventQueue();
-    await waitForTasksFinished();
-
-    verifyStrongMode(enabled: false);
-  }
-
-  test_strong_mode_changed_on() async {
-    setStrongMode(false);
-
-    addTestFile(testSource);
-    setAnalysisRoot();
-
-    await waitForTasksFinished();
-
-    verifyStrongMode(enabled: false);
-
-    setStrongMode(true);
-
-    await pumpEventQueue();
-    await waitForTasksFinished();
-
-    verifyStrongMode(enabled: true);
+    expect(analysisOptions.lint, false);
   }
 
   void verifyLintsEnabled(List<String> lints) {
@@ -297,21 +259,6 @@ linter:
     var rules = options.lintRules.map((rule) => rule.name);
     expect(rules, unorderedEquals(lints));
   }
-
-  verifyStrongMode({bool enabled}) {
-    // Verify strong-mode enabled.
-    expect(analysisOptions.strongMode, enabled);
-
-    if (enabled) {
-      // Should produce a type warning.
-      expect(errors.map((error) => error.type),
-          unorderedEquals([AnalysisErrorType.STATIC_TYPE_WARNING]));
-    } else {
-      // Should only produce a hint.
-      expect(errors.map((error) => error.type),
-          unorderedEquals([AnalysisErrorType.HINT]));
-    }
-  }
 }
 
 @reflectiveTest

pkg/analysis_server/test/analysis/notification_errors_test.dart

@@ -188,7 +188,8 @@ version: 1.3.2
     createProject();
     addTestFile('''
 main() {
-  print(UNKNOWN);
+  final int foo;
+  print(foo);
 }
 ''');
     await waitForTasksFinished();

pkg/analysis_server/test/completion_test.dart

@@ -294,27 +294,6 @@ void r() {
   }
 }''', <String>["1+toUpperCase", "2-getKeys"]);
 
-    // Type propagation.
-    buildTests('testCommentSnippets053', '''
-class String{int length(){} String toUpperCase(){} bool isEmpty(){}}class Map{getKeys(){}}
-void r() {
-  var v;
-  while (v is String) {
-    v.!1toUpperCase;
-    v.!2getKeys;
-  }
-}''', <String>["1+toUpperCase", "2-getKeys"]);
-
-    buildTests('testCommentSnippets054', '''
-class String{int length(){} String toUpperCase(){} bool isEmpty(){}}class Map{getKeys(){}}
-void r() {
-  var v;
-  for (; v is String; v.!1isEmpty) {
-    v.!2toUpperCase;
-    v.!3getKeys;
-  }
-}''', <String>["1+isEmpty", "2+toUpperCase", "3-getKeys"]);
-
     buildTests('testCommentSnippets055', '''
 class String{int length(){} String toUpperCase(){} bool isEmpty(){}}class Map{getKeys(){}}
 void r() {
@@ -324,25 +303,6 @@ void r() {
   }
 }''', <String>["1+toUpperCase"]);
 
-    // Type propagation.
-    buildTests('testCommentSnippets056', '''
-class String{int length(){} String toUpperCase(){} bool isEmpty(){}}class Map{getKeys(){}}
-void f(var v) {
-  if (v is!! String) {
-    return;
-  }
-  v.!1toUpperCase;
-}''', <String>["1+toUpperCase"]);
-
-    // Type propagation.
-    buildTests('testCommentSnippets057', '''
-class String{int length(){} String toUpperCase(){} bool isEmpty(){}}class Map{getKeys(){}}
-void f(var v) {
-  if ((v as String).!2length == 0) {
-    v.!1toUpperCase;
-  }
-}''', <String>["1+toUpperCase", "2+length"]);
-
     buildTests(
         'testCommentSnippets058',
         '''
@@ -372,15 +332,6 @@ class Z {
 class A{m(){!1f(3);!2}}n(){!3f(3);!4}f(x)=>x*3;''',
         <String>["1+f", "1+n", "2+f", "2+n", "3+f", "3+n", "4+f", "4+n"]);
 
-    // Type propagation.
-    buildTests('testCommentSnippets063', '''
-class String{int length(){} String toUpperCase(){} bool isEmpty(){}}class Map{getKeys(){}}
-void r(var v) {
-  v.!1toUpperCase;
-  assert(v is String);
-  v.!2toUpperCase;
-}''', <String>["1-toUpperCase", "2+toUpperCase"]);
-
     buildTests('testCommentSnippets064', '''
 class Spline {
   Line c;
@@ -2363,8 +2314,7 @@ class A {
 
     // test analysis of untyped fields and top-level vars
     buildTests('test035', '''class Y {final x='hi';mth() {x.!1length;}}''',
-        <String>["1+length"],
-        failingTests: '1');
+        <String>["1+length"]);
 
     // TODO(scheglov) decide what to do with Type for untyped field (not
     // supported by the new store)

pkg/analyzer/lib/src/command_line/arguments.dart

@@ -116,7 +116,7 @@ ContextBuilderOptions createContextBuilderOptions(ArgResults args,
   // Declared variables.
   //
   Map<String, String> declaredVariables = <String, String>{};
-  List<String> variables = args[defineVariableOption] as List<String>;
+  List<String> variables = (args[defineVariableOption] as List).cast<String>();
   for (String variable in variables) {
     int index = variable.indexOf('=');
     if (index < 0) {