Skip to content

Commit be229bb

Browse files
committed
Be slighly more sophistcated in determining what is a valid version number
1 parent baa61db commit be229bb

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

getLatestRelease.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,10 @@ def getGithubToken():
2828
token = None
2929
return token
3030

31+
def isVersionNum(release):
32+
# Assume any release name that has 1-4 '.' or '-' in it and NO spaces is a valid version number
33+
return ((release.count('-') > 0 and release.count('-') < 5) or (release.count('.') > 0 and release.count('.'))) and (release.count(' ') == 0)
34+
3135
def get_latest_release(user=None, repo=None, tag=None, latest=False, token=None, quiet=False):
3236
#
3337

@@ -43,17 +47,17 @@ def get_latest_release(user=None, repo=None, tag=None, latest=False, token=None,
4347
releases_url = "{0}/releases".format(repo_url)
4448
tags_url = "{0}/tags".format(repo_url)
4549

46-
#print(releases_url)
50+
print(releases_url)
4751

4852
latest_release = None
4953

5054
releases = doRequest(releases_url, headers)
51-
#pPrint(releases)
55+
pPrint(releases)
5256
for release in releases:
5357
#!print_release_info(release, repo, save=False)
5458

5559
# Assume the first release that starts with 'R' is the latest release
56-
if release["name"][0] == 'R':
60+
if isVersionNum(release["name"]):
5761
latest_release = release["name"]
5862
break
5963

@@ -63,7 +67,7 @@ def get_latest_release(user=None, repo=None, tag=None, latest=False, token=None,
6367

6468
for tag in tags:
6569
# Assume the first tag that starts with 'R' is the latest release
66-
if tag["name"][0] == 'R':
70+
if isVersionNum(tag["name"]):
6771
latest_release = tag["name"]
6872
break
6973

0 commit comments

Comments
 (0)