Skip to content

Commit 4b5158e

Browse files
ofrobotsstephenplusplus
authored andcommitted
logging-winston: make winston a peerDependency (googleapis#2453)
Users of this library need to depend on winston directly. There are scenarios where the user, or other libraries may depend on a semver incompatible version of winston. Not only does it end up installing an unnecessary copy of winston; it may also lead to our transport not being visible in `winston.transports` that the user has visibility to.
1 parent 193e747 commit 4b5158e

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

packages/logging-winston/package.json

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,15 @@
3232
"@google-cloud/logging": "^1.0.0",
3333
"extend": "^3.0.0",
3434
"is": "^3.2.0",
35-
"lodash.mapvalues": "^4.6.0",
36-
"winston": "^2.2.0"
35+
"lodash.mapvalues": "^4.6.0"
36+
},
37+
"peerDependencies": {
38+
"winston": "^2.x"
3739
},
3840
"devDependencies": {
3941
"mocha": "^3.2.0",
40-
"proxyquire": "^1.7.10"
42+
"proxyquire": "^1.7.10",
43+
"winston": "^2.2.0"
4144
},
4245
"scripts": {
4346
"publish-module": "node ../../scripts/publish.js logging-winston",

0 commit comments

Comments
 (0)