Skip to content

Commit 51013af

Browse files
committed
Fixed a bug with FacetedSearchForm where cleaned_data may not exist. Thanks to imageinary for the report!
1 parent 6edefc2 commit 51013af

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

haystack/forms.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ class FacetedSearchForm(SearchForm):
6969
def search(self):
7070
sqs = super(FacetedSearchForm, self).search()
7171

72-
if self.cleaned_data['selected_facets']:
72+
if hasattr(self, 'cleaned_data') and self.cleaned_data['selected_facets']:
7373
sqs = sqs.narrow(self.cleaned_data['selected_facets'])
7474

7575
return sqs
@@ -106,7 +106,7 @@ class FacetedModelSearchForm(ModelSearchForm):
106106
def search(self):
107107
sqs = super(FacetedModelSearchForm, self).search()
108108

109-
if self.cleaned_data['selected_facets']:
109+
if hasattr(self, 'cleaned_data') and self.cleaned_data['selected_facets']:
110110
sqs = sqs.narrow(self.cleaned_data['selected_facets'])
111111

112112
return sqs.models(*self.get_models())

tests/core/urls.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
from django.conf.urls.defaults import *
22
from haystack.backends.dummy_backend import SearchBackend, SearchQuery
3+
from haystack.forms import FacetedSearchForm
34
from haystack.query import SearchQuerySet
45
from haystack.views import SearchView, FacetedSearchView
56

@@ -15,6 +16,6 @@
1516

1617
urlpatterns += patterns('haystack.views',
1718
url(r'^$', SearchView(load_all=False), name='haystack_search'),
18-
url(r'^faceted/$', FacetedSearchView(searchqueryset=SearchQuerySet().facet('author')), name='haystack_faceted_search'),
19+
url(r'^faceted/$', FacetedSearchView(searchqueryset=SearchQuerySet().facet('author'), form_class=FacetedSearchForm), name='haystack_faceted_search'),
1920
url(r'^basic/$', 'basic_search', {'load_all': False}, name='haystack_basic_search'),
2021
)

0 commit comments

Comments
 (0)