Skip to content

Commit c5f8f1a

Browse files
robhudsontoastdriven
authored andcommitted
The SearchAdmin now correctly uses SEARCH_VAR instead of assuming things.
1 parent 453aa69 commit c5f8f1a

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

haystack/admin.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
from django.contrib.admin.options import ModelAdmin
2-
from django.contrib.admin.views.main import ChangeList, MAX_SHOW_ALL_ALLOWED
2+
from django.contrib.admin.views.main import (ChangeList, MAX_SHOW_ALL_ALLOWED,
3+
SEARCH_VAR)
34
from django.core.exceptions import PermissionDenied, ImproperlyConfigured
45
from django.core.paginator import Paginator, InvalidPage
56
from django.shortcuts import render_to_response
@@ -24,11 +25,11 @@ def wraps(request, *args, **kwargs):
2425

2526
class SearchChangeList(ChangeList):
2627
def get_results(self, request):
27-
if not 'q' in request.GET:
28+
if not SEARCH_VAR in request.GET:
2829
return super(SearchChangeList, self).get_results(request)
2930

3031
# Note that pagination is 0-based, not 1-based.
31-
sqs = SearchQuerySet().models(self.model).auto_query(request.GET['q']).load_all()
32+
sqs = SearchQuerySet().models(self.model).auto_query(request.GET[SEARCH_VAR]).load_all()
3233

3334
paginator = Paginator(sqs, self.list_per_page)
3435
# Get the number of objects, with admin filters applied.
@@ -61,7 +62,7 @@ def changelist_view(self, request, extra_context=None):
6162
if not self.has_change_permission(request, None):
6263
raise PermissionDenied
6364

64-
if not 'q' in request.GET:
65+
if not SEARCH_VAR in request.GET:
6566
# Do the usual song and dance.
6667
return super(SearchModelAdmin, self).changelist_view(request, extra_context)
6768

0 commit comments

Comments
 (0)