Skip to content

Commit f16767c

Browse files
tmctoastdriven
authored andcommitted
Moved handle_facet_parameters call into FacetField's __init__.
1 parent 74f73a1 commit f16767c

File tree

1 file changed

+18
-44
lines changed

1 file changed

+18
-44
lines changed

haystack/fields.py

Lines changed: 18 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -292,6 +292,10 @@ class FacetField(SearchField):
292292
"""
293293
instance_name = None
294294

295+
def __init__(self, **kwargs):
296+
handled_kwargs = self.handle_facet_parameters(kwargs)
297+
super(FacetField, self).__init__(**handled_kwargs)
298+
295299
def handle_facet_parameters(self, kwargs):
296300
if kwargs.get('faceted', False):
297301
raise SearchFieldError("FacetField (%s) does not accept the 'faceted' argument." % self.instance_name)
@@ -321,57 +325,27 @@ def get_facet_for_name(self):
321325
return self.facet_for or self.instance_name
322326

323327

324-
class FacetCharField(CharField, FacetField):
325-
field_type = 'string'
326-
327-
def __init__(self, **kwargs):
328-
handled_kwargs = self.handle_facet_parameters(kwargs)
329-
super(FacetCharField, self).__init__(**handled_kwargs)
330-
331-
332-
class FacetIntegerField(IntegerField, FacetField):
333-
field_type = 'integer'
328+
class FacetCharField(FacetField, CharField):
329+
pass
334330

335-
def __init__(self, **kwargs):
336-
handled_kwargs = self.handle_facet_parameters(kwargs)
337-
super(FacetIntegerField, self).__init__(**handled_kwargs)
338-
339-
340-
class FacetFloatField(FloatField, FacetField):
341-
field_type = 'float'
331+
class FacetIntegerField(FacetField, IntegerField):
332+
pass
342333

343-
def __init__(self, **kwargs):
344-
handled_kwargs = self.handle_facet_parameters(kwargs)
345-
super(FacetFloatField, self).__init__(**handled_kwargs)
334+
class FacetFloatField(FacetField, FloatField):
335+
pass
346336

347337

348-
class FacetBooleanField(BooleanField, FacetField):
349-
field_type = 'boolean'
350-
351-
def __init__(self, **kwargs):
352-
handled_kwargs = self.handle_facet_parameters(kwargs)
353-
super(FacetBooleanField, self).__init__(**handled_kwargs)
338+
class FacetBooleanField(FacetField, BooleanField):
339+
pass
354340

355341

356-
class FacetDateField(DateField, FacetField):
357-
field_type = 'date'
358-
359-
def __init__(self, **kwargs):
360-
handled_kwargs = self.handle_facet_parameters(kwargs)
361-
super(FacetDateField, self).__init__(**handled_kwargs)
342+
class FacetDateField(FacetField, DateField):
343+
pass
362344

363345

364-
class FacetDateTimeField(DateTimeField, FacetField):
365-
field_type = 'datetime'
366-
367-
def __init__(self, **kwargs):
368-
handled_kwargs = self.handle_facet_parameters(kwargs)
369-
super(FacetDateTimeField, self).__init__(**handled_kwargs)
346+
class FacetDateTimeField(FacetField, DateTimeField):
347+
pass
370348

371349

372-
class FacetMultiValueField(MultiValueField, FacetField):
373-
field_type = 'string'
374-
375-
def __init__(self, **kwargs):
376-
handled_kwargs = self.handle_facet_parameters(kwargs)
377-
super(FacetMultiValueField, self).__init__(**handled_kwargs)
350+
class FacetMultiValueField(FacetField, MultiValueField):
351+
pass

0 commit comments

Comments
 (0)