Skip to content

Compose multi-arch image manifests for a containerdisk #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jbpratt opened this issue May 31, 2022 · 8 comments
Closed

Compose multi-arch image manifests for a containerdisk #41

jbpratt opened this issue May 31, 2022 · 8 comments
Labels
kind/enhancement lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@jbpratt
Copy link

jbpratt commented May 31, 2022

Is this a BUG REPORT or FEATURE REQUEST?:

/kind enhancement

Hi 😺

I'm curious about whether handling non-x86_64 images has been discussed yet and if it is something that is in scope/worth the time to invest. While I haven't been keeping it up the best, and it is mostly just ran by automation at this point, we did have success with publishing multi-arch image manifests (only amd64 and arm64) of the container disks we build to then boot those. Every image currently supported (and more!) within kubevirt/containerdisks should have a compatible aarch64 image existing for download (at least I've done it for Debian, Ubuntu, Fedora, FCOS, Centos, Rocky, and AlmaLinux).

I'm not sure how testing is currently happening of these images or if we are running these through Prow for validation, that may be even more difficult with aarch64 images if there is limited hardware.

(linking to kubevirt/kubevirt#3558)

@rmohr
Copy link
Member

rmohr commented Jul 13, 2022

I think, in general nothing speaks against that. The main issue probably is testing them. The x86_64 images are tested as part of the publish flow (so only very-likely working content gets released).

@rmohr
Copy link
Member

rmohr commented Jul 13, 2022

@0xFelix FYI

@kubevirt-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubevirt-bot kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 11, 2022
@jbpratt
Copy link
Author

jbpratt commented Oct 11, 2022

/remove-lifecycle stale

@kubevirt-bot kubevirt-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 11, 2022
@kubevirt-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubevirt-bot kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 9, 2023
@kubevirt-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@kubevirt-bot kubevirt-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 8, 2023
@kubevirt-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

@kubevirt-bot
Copy link
Contributor

@kubevirt-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

3 participants