-
Notifications
You must be signed in to change notification settings - Fork 27
CI should run promote with dry run disabled #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with /lifecycle rotten |
/remove-lifecycle stale |
Rotten issues close after 30d of inactivity. /close |
@kubevirt-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Uh oh!
There was an error while loading. Please reload this page.
CI is running
promote
stage in dry run, it means dry run is enabled and the actual code that is pushing the image to remote container registry is not executed. We should improve testing of it, and not use dry run in CI to test changes [1].[1] https://github.com/kubevirt/containerdisks/blob/main/pipeline.sh#L13
The text was updated successfully, but these errors were encountered: