Avoid using mutable default arguments where possible.

Author: lamby

django/contrib/gis/maps/google/gmap.py

@@ -29,10 +29,10 @@ class GoogleMap(object):
 
     def __init__(self, key=None, api_url=None, version=None,
                  center=None, zoom=None, dom_id='map',
-                 kml_urls=[], polylines=None, polygons=None, markers=None,
+                 kml_urls=(), polylines=None, polygons=None, markers=None,
                  template='gis/google/google-map.js',
                  js_module='geodjango',
-                 extra_context={}):
+                 extra_context=None):
 
         # The Google Maps API Key defined in the settings will be used
         # if not passed in as a parameter.  The use of an API key is
@@ -64,7 +64,7 @@ def __init__(self, key=None, api_url=None, version=None,
         # Setting the DOM id of the map, the load function, the JavaScript
         # template, and the KML URLs array.
         self.dom_id = dom_id
-        self.extra_context = extra_context
+        self.extra_context = extra_context or {}
         self.js_module = js_module
         self.template = template
         self.kml_urls = kml_urls

django/db/backends/base/schema.py

@@ -94,7 +94,7 @@ def __exit__(self, exc_type, exc_value, traceback):
 
     # Core utility functions
 
-    def execute(self, sql, params=[]):
+    def execute(self, sql, params=()):
         """
         Executes the given SQL statement, with optional parameters.
         """

django/db/models/fields/__init__.py

@@ -142,7 +142,7 @@ def __init__(self, verbose_name=None, name=None, primary_key=False,
                  db_index=False, rel=None, default=NOT_PROVIDED, editable=True,
                  serialize=True, unique_for_date=None, unique_for_month=None,
                  unique_for_year=None, choices=None, help_text='', db_column=None,
-                 db_tablespace=None, auto_created=False, validators=[],
+                 db_tablespace=None, auto_created=False, validators=(),
                  error_messages=None):
         self.name = name
         self.verbose_name = verbose_name  # May be set by set_attributes_from_name
@@ -175,7 +175,7 @@ def __init__(self, verbose_name=None, name=None, primary_key=False,
             self.creation_counter = Field.creation_counter
             Field.creation_counter += 1
 
-        self._validators = validators  # Store for deconstruction later
+        self._validators = list(validators)  # Store for deconstruction later
 
         messages = {}
         for c in reversed(self.__class__.__mro__):

django/forms/fields.py

@@ -62,7 +62,7 @@ class Field(object):
 
     def __init__(self, required=True, widget=None, label=None, initial=None,
                  help_text='', error_messages=None, show_hidden_initial=False,
-                 validators=[], localize=False, disabled=False, label_suffix=None):
+                 validators=(), localize=False, disabled=False, label_suffix=None):
         # required -- Boolean that specifies whether the field is required.
         #             True by default.
         # widget -- A Widget class, or instance of a Widget class, that should