Skip to content

Commit 25791b0

Browse files
committed
fix variable shadowing
1 parent 907617b commit 25791b0

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

README.md

+7-7
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,7 @@ const menuConfig = {
226226
cancellable: true
227227
}
228228

229-
function createMenu(menuConfig) {
229+
function createMenu(config) {
230230
// ...
231231
}
232232

@@ -1699,14 +1699,14 @@ Promises are a built-in global type. Use them!
16991699

17001700
**Bad:**
17011701
```javascript
1702-
require('request').get('https://en.wikipedia.org/wiki/Robert_Cecil_Martin', function(err, response) {
1703-
if (err) {
1704-
console.error(err);
1702+
require('request').get('https://en.wikipedia.org/wiki/Robert_Cecil_Martin', (requestErr, response) => {
1703+
if (requestErr) {
1704+
console.error(requestErr);
17051705
}
17061706
else {
1707-
require('fs').writeFile('article.html', response.body, function(err) {
1708-
if (err) {
1709-
console.error(err);
1707+
require('fs').writeFile('article.html', response.body, (writeErr) => {
1708+
if (writeErr) {
1709+
console.error(writeErr);
17101710
} else {
17111711
console.log('File written');
17121712
}

0 commit comments

Comments
 (0)