Skip to content

Commit 3369c52

Browse files
Merge pull request ryanmcdermott#80 from vsemozhetbyt/comment-out-ellipses
comment out all the ellipses consistently
2 parents 5c2f16a + f9fb078 commit 3369c52

File tree

1 file changed

+17
-17
lines changed

1 file changed

+17
-17
lines changed

README.md

+17-17
Original file line numberDiff line numberDiff line change
@@ -118,9 +118,9 @@ const locations = ['Austin', 'New York', 'San Francisco'];
118118
locations.forEach((l) => {
119119
doStuff();
120120
doSomeOtherStuff();
121-
...
122-
...
123-
...
121+
// ...
122+
// ...
123+
// ...
124124
// Wait, what is `l` for again?
125125
dispatch(l);
126126
});
@@ -132,9 +132,9 @@ const locations = ['Austin', 'New York', 'San Francisco'];
132132
locations.forEach((location) => {
133133
doStuff();
134134
doSomeOtherStuff();
135-
...
136-
...
137-
...
135+
// ...
136+
// ...
137+
// ...
138138
dispatch(location);
139139
});
140140
```
@@ -213,7 +213,7 @@ lot of arguments.
213213
**Bad:**
214214
```javascript
215215
function createMenu(title, body, buttonText, cancellable) {
216-
...
216+
// ...
217217
}
218218
```
219219

@@ -227,7 +227,7 @@ const menuConfig = {
227227
}
228228

229229
function createMenu(menuConfig) {
230-
...
230+
// ...
231231
}
232232

233233
```
@@ -335,7 +335,7 @@ function tokenize(code) {
335335
const tokens = [];
336336
REGEXES.forEach((REGEX) => {
337337
statements.forEach((statement) => {
338-
tokens.push( // ... );
338+
tokens.push( /* ... */ );
339339
})
340340
});
341341

@@ -345,7 +345,7 @@ function tokenize(code) {
345345
function lexer(tokens) {
346346
const ast = [];
347347
tokens.forEach((token) => {
348-
ast.push( // ... );
348+
ast.push( /* ... */ );
349349
});
350350

351351
return ast;
@@ -441,7 +441,7 @@ function writeForumComment(subject, body) {
441441
**Good**:
442442
```javascript
443443
function writeForumComment(subject = 'No subject', body = 'No text') {
444-
...
444+
// ...
445445
}
446446

447447
```
@@ -683,7 +683,7 @@ const totalOutput = programmerOutput
683683
**Bad:**
684684
```javascript
685685
if (fsm.state === 'fetching' && isEmpty(listNode)) {
686-
/// ...
686+
// ...
687687
}
688688
```
689689

@@ -737,7 +737,7 @@ just do one thing.
737737
**Bad:**
738738
```javascript
739739
class Airplane {
740-
//...
740+
// ...
741741
getCruisingAltitude() {
742742
switch (this.type) {
743743
case '777':
@@ -754,25 +754,25 @@ class Airplane {
754754
**Good**:
755755
```javascript
756756
class Airplane {
757-
//...
757+
// ...
758758
}
759759

760760
class Boeing777 extends Airplane {
761-
//...
761+
// ...
762762
getCruisingAltitude() {
763763
return getMaxAltitude() - getPassengerCount();
764764
}
765765
}
766766

767767
class AirForceOne extends Airplane {
768-
//...
768+
// ...
769769
getCruisingAltitude() {
770770
return getMaxAltitude();
771771
}
772772
}
773773

774774
class Cessna extends Airplane {
775-
//...
775+
// ...
776776
getCruisingAltitude() {
777777
return getMaxAltitude() - getFuelExpenditure();
778778
}

0 commit comments

Comments
 (0)