Skip to content

Commit 713c6a0

Browse files
committed
fixed broken path tests
normally I wouldn't accept re-ordering of tests as a solution to any problem, but the issue here was multiple changepage events overlapping during our tests. generally we have browser state issues in our test suite and we need a general solution for them which will come post 1.0
1 parent adf55d0 commit 713c6a0

File tree

1 file changed

+19
-20
lines changed

1 file changed

+19
-20
lines changed

tests/unit/navigation/navigation_core.js

Lines changed: 19 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -930,26 +930,6 @@
930930
]);
931931
});
932932

933-
asyncTest( "prefetched links with data rel dialog result in a dialog", function() {
934-
$.testHelper.pageSequence([
935-
// open our test page
936-
function(){
937-
// Navigate to any page except the first page of the application.
938-
$.testHelper.openPage("#prefetched-dialog-page");
939-
},
940-
941-
function() {
942-
$("#prefetched-dialog-link").click();
943-
},
944-
945-
function() {
946-
ok( $.mobile.activePage.is(".ui-dialog"), "prefetched page is rendered as a dialog" );
947-
start();
948-
}
949-
]);
950-
});
951-
952-
953933
asyncTest( "application url with dialogHashKey loads application's first page", function(){
954934
$.testHelper.pageSequence([
955935
// open our test page
@@ -977,4 +957,23 @@
977957
}
978958
]);
979959
});
960+
961+
asyncTest( "prefetched links with data rel dialog result in a dialog", function() {
962+
$.testHelper.pageSequence([
963+
// open our test page
964+
function(){
965+
// Navigate to any page except the first page of the application.
966+
$.testHelper.openPage("#prefetched-dialog-page");
967+
},
968+
969+
function() {
970+
$("#prefetched-dialog-link").click();
971+
},
972+
973+
function() {
974+
ok( $.mobile.activePage.is(".ui-dialog"), "prefetched page is rendered as a dialog" );
975+
start();
976+
}
977+
]);
978+
});
980979
})(jQuery);

0 commit comments

Comments
 (0)