Skip to content

Commit 35c53fc

Browse files
AthinaPlphrdina
authored andcommitted
cli: Add --disk rawio
XML mapping: <disk type=... rawio="yes"> ... </disk> Signed-off-by: Athina Plaskasoviti <[email protected]> Reviewed-by: Fabiano Fidêncio <[email protected]>
1 parent 0b4c6dd commit 35c53fc

File tree

6 files changed

+6
-3
lines changed

6 files changed

+6
-3
lines changed

tests/cli-test-xml/compare/virt-install-many-devices.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@
7070
<source file="/var/lib/libvirt/images/foobar.qcow2"/>
7171
<target dev="vdc" bus="virtio"/>
7272
</disk>
73-
<disk type="block" device="lun" sgio="unfiltered">
73+
<disk type="block" device="lun" sgio="unfiltered" rawio="yes">
7474
<driver name="qemu" type="raw"/>
7575
<source dev="/iscsi-pool/diskvol1"/>
7676
<target dev="sdab" bus="scsi"/>

tests/clitest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -550,7 +550,7 @@ def add_compare(self, cat, args, compbase, **kwargs):
550550
--disk %(NEWIMG1)s,sparse=false,size=.001,perms=ro,error_policy=enospace,discard=unmap,detect_zeroes=unmap,address.type=drive,address.controller=0,address.target=2,address.unit=0
551551
--disk device=cdrom,bus=sata,read_bytes_sec=1,read_iops_sec=2,write_bytes_sec=5,write_iops_sec=6,driver.copy_on_read=on,geometry.cyls=16383,geometry.heads=16,geometry.secs=63,geometry.trans=lba
552552
--disk size=1
553-
--disk /iscsi-pool/diskvol1,total_bytes_sec=10,total_iops_sec=20,bus=scsi,device=lun,sgio=unfiltered
553+
--disk /iscsi-pool/diskvol1,total_bytes_sec=10,total_iops_sec=20,bus=scsi,device=lun,sgio=unfiltered,rawio=yes
554554
--disk /dev/default-pool/iso-vol,seclabel.model=dac,seclabel1.model=selinux,seclabel1.relabel=no,seclabel0.label=foo,bar,baz,iotune.read_bytes_sec=1,iotune.read_iops_sec=2,iotune.write_bytes_sec=5,iotune.write_iops_sec=6
555555
--disk /dev/default-pool/iso-vol,format=qcow2,startup_policy=optional,iotune.total_bytes_sec=10,iotune.total_iops_sec=20,
556556
--disk source_pool=rbd-ceph,source_volume=some-rbd-vol,size=.1,driver_type=raw

tests/xmlparse-xml/change-disk-out.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
<disk type="file" device="floppy">
3838
<target dev="fde" bus="fdc"/>
3939
</disk>
40-
<disk type="block" device="lun" sgio="unfiltered">
40+
<disk type="block" device="lun" sgio="unfiltered" rawio="yes">
4141
<driver name="qemu" type="raw"/>
4242
<source dev="/dev/sda"/>
4343
<target dev="hdd" bus="scsi"/>

tests/xmlparse.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -403,6 +403,7 @@ def _get_disk(target):
403403
check("type", "block")
404404
check("device", "lun")
405405
check("sgio", None, "unfiltered")
406+
check("rawio", None, "yes")
406407

407408
disk = _get_disk("sda")
408409
check = self._make_checker(disk)

virtinst/cli.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2911,6 +2911,7 @@ def _init_class(cls, **kwargs):
29112911
cls.add_arg("device", "device")
29122912
cls.add_arg("snapshot", "snapshot_policy")
29132913
cls.add_arg("sgio", "sgio")
2914+
cls.add_arg("rawio", "rawio")
29142915
cls.add_arg("serial", "serial")
29152916
cls.add_arg("wwn", "wwn")
29162917
cls.add_arg("readonly", "read_only", is_onoff=True)

virtinst/devices/disk.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -643,6 +643,7 @@ def _set_device(self, val):
643643
driver_copy_on_read = XMLProperty("./driver/@copy_on_read", is_onoff=True)
644644

645645
sgio = XMLProperty("./@sgio")
646+
rawio = XMLProperty("./@rawio")
646647

647648
bus = XMLProperty("./target/@bus")
648649
target = XMLProperty("./target/@dev")

0 commit comments

Comments
 (0)