[2.0] Cannot load dependent fixtures that needs dependency injection

[magnetik]

Using DoctrineFixtures and LiipFunctionalTestBundle.
Let's say I've FooFixtures that requires BarFixtures and BarFixtures requires a service injected in it's constructor.

In my test, I use $this->loadfixtures([FooFictures::class]);.
This ends up in the FixturesLoaderFactory line 65: $loader->addFixture($fixture);
This calls the \Doctrine\Common\DataFixtures\Loader line 136 that tries to manage dependencies: elseif ($fixture instanceof DependentFixtureInterface) { $this->addFixture($this->createFixture($class));

So if my BarFixtures needs a service in the construct, it cannot be instantiated.

Should the SymfonyFixturesLoader from the DoctrineFixtureBundle be used?

Thanks

[magnetik]

Related: doctrine/DoctrineFixturesBundle@ee5eb61#diff-054595578db32911a949ec0d1754d3c6

[Jean85]

As pointed out in #413 (comment), there's a decision to be made in regards of the DoctrineFixtureBundle:

[...] have to either require it in the composer.json, or make this optional (and add approriate check later in the code).

I heavily lean on the latter, since requiring an entire Doctrine bundle where it could not be wanted is too hard of a requirement.

[alexislefebvre]

There is a conversation about dependencies in a Doctrine Data Fixtures issue: doctrine/data-fixtures#291

[magnetik]

To have it working as soon as possible, I'll update my pull request to load the service SymfonyFixturesLoader only if it's present, and keep the old behavior otherwise.

Does it looks OK to you all?

[Jean85]

Looks like a good solution for me! 👍

[magnetik]

I tried to implement it, but it was.. messy to come up with something working in both old and new case.

If the doctrine fixtures bundle is loaded, then ALL your fixtures have to be services, and be tagged with doctrine.orm.fixtures (it's the way the SymfonyFixturesLoader works).

The readme states:

If you plan on loading fixtures with your tests, make sure you have the DoctrineFixturesBundle installed and configured first:

If the DoctrineFixturesBundle is mandatory it's way easier to implement.

[StanislavUngr]

Is there any solution to this problem so far? This bug makes the bundle unusable for our team :/

[magnetik]

There is no solution besides using the quick and dirty fix from PR #413 (I'm using it internally)

[magnetik]

I tried a little more. And I cannot come up with a solution that is not exactly the same as reimplementing the "SymfonyFixturesLoader" from the doctrine fixtures bundle.

if the DoctrineFixtureBundle an hard dependency we should just use this loader directly.

[alexislefebvre]

if the DoctrineFixtureBundle an hard dependency we should just use this loader directly.

I don't see any reason to not rely on SymfonyFixturesLoader. As long as it doesn't break to many things, we can use it and include this change on the 2.x branch.