Factor out bool encoding function.

Sets `true` to `1` and `false` to `0`.

Author: IslandUsurper

src/eipmi_request.erl

@@ -177,12 +177,7 @@ encode_storage(Req, _Properties) when
 %% @private
 %%------------------------------------------------------------------------------
 encode_transport(?GET_IP_UDP_RMCP_STATISTICS, Properties) ->
-    Clear = proplists:get_value(clear_statistics, Properties, false),
-    C =
-        case Clear of
-            true -> 1;
-            false -> 0
-        end,
+    C = get_encoded_bool(clear_statistics, Properties),
     <<0:4, ?IPMI_REQUESTED_CHANNEL:4, 0:7, C:1>>;
 encode_transport(?SET_LAN_CONFIGURATION_PARAMETERS, Properties) ->
     P = proplists:get_value(parameter, Properties),
@@ -239,11 +234,7 @@ encode_transport(?SET_LAN_CONFIGURATION_PARAMETERS, Properties) ->
                         oem1 -> 6;
                         oem2 -> 7
                     end,
-                A =
-                    case proplists:get_value(acknowledge, Properties, false) of
-                        true -> 1;
-                        false -> 0
-                    end,
+                A = get_encoded_bool(acknowledge, Properties),
                 To = proplists:get_value(timeout, Properties, 0),
                 R = proplists:get_value(retries, Properties, 0),
                 <<0:4, S:4, A:1, 0:4, T:3, To:8, 0:5, R:3>>;
@@ -291,18 +282,8 @@ encode_chassis(?CHASSIS_IDENTIFY, Properties) ->
             <<0:8, 0:7, 1:1>>
     end;
 encode_chassis(?SET_CHASSIS_CAPABILITIES, Properties) ->
-    Lockout = proplists:get_bool(lockout, Properties),
-    L =
-        case Lockout of
-            true -> 1;
-            false -> 0
-        end,
-    Intrusion = proplists:get_bool(intrusion, Properties),
-    I =
-        case Intrusion of
-            true -> 1;
-            false -> 0
-        end,
+    L = get_encoded_bool(lockout, Properties),
+    I = get_encoded_bool(intrusion, Properties),
     F = proplists:get_value(fru_address, Properties),
     Sdr = proplists:get_value(sdr_address, Properties),
     Sel = proplists:get_value(sel_address, Properties),
@@ -324,30 +305,10 @@ encode_chassis(?SET_POWER_RESTORE_POLICY, Properties) ->
         end,
     <<0:5, P:3>>;
 encode_chassis(?SET_FRONT_PANEL_ENABLES, Properties) ->
-    Standby = proplists:get_bool(disable_standby, Properties),
-    S =
-        case Standby of
-            true -> 1;
-            false -> 0
-        end,
-    Diagnostic = proplists:get_bool(disable_diagnostic_interrupt, Properties),
-    D =
-        case Diagnostic of
-            true -> 1;
-            false -> 0
-        end,
-    Reset = proplists:get_bool(disable_reset, Properties),
-    R =
-        case Reset of
-            true -> 1;
-            false -> 0
-        end,
-    Power = proplists:get_bool(disable_power, Properties),
-    P =
-        case Power of
-            true -> 1;
-            false -> 0
-        end,
+    S = get_encoded_bool(disable_standby, Properties),
+    D = get_encoded_bool(disable_diagnostic_interrupt, Properties),
+    R = get_encoded_bool(disable_reset, Properties),
+    P = get_encoded_bool(disable_power, Properties),
     <<0:4, S:1, D:1, R:1, P:1>>;
 encode_chassis(?SET_POWER_CYCLE_INTERVAL, Properties) ->
     I = proplists:get_value(interval, Properties, 0),
@@ -392,12 +353,8 @@ encode_picmg(?GET_FRU_ACTIVATION_POLICY, Properties) ->
     <<?PICMG_ID:8, FruId:8>>;
 encode_picmg(?SET_FRU_ACTIVATION, Properties) ->
     FruId = proplists:get_value(fru_id, Properties),
-    Activate = proplists:get_value(activate, Properties),
-    <<?PICMG_ID:8, FruId:8,
-        (case Activate of
-            true -> 1;
-            false -> 0
-        end):8>>;
+    Activate = get_encoded_bool(activate, Properties),
+    <<?PICMG_ID:8, FruId:8, Activate:8>>;
 encode_picmg(?FRU_CONTROL, Properties) ->
     FruId = proplists:get_value(fru_id, Properties),
     Control = proplists:get_value(control, Properties),
@@ -523,3 +480,9 @@ encode_picmg_site_type(pmc) -> 16#08;
 encode_picmg_site_type(rear_transition_module) -> 16#09;
 encode_picmg_site_type(mch) -> 16#0a;
 encode_picmg_site_type(power_module) -> 16#0b.
+
+get_encoded_bool(Prop, List) ->
+    case proplists:get_bool(Prop, List) of
+        true -> 1;
+        false -> 0
+    end.