Skip to content

Image::crop() removed! #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gbmbg opened this issue Apr 15, 2025 · 6 comments
Closed

Image::crop() removed! #32

gbmbg opened this issue Apr 15, 2025 · 6 comments

Comments

@gbmbg
Copy link

gbmbg commented Apr 15, 2025

Good Morning,
looking through the changelog of release 1.11-rc3 we found that the image::crop() method has been removed.
We usually employ it in our projects, are you planning to introduce anything similar? Dou you suggest any other method to do the same thing?
Thanks a lot and have a nice day

@ldesroches
Copy link
Contributor

Hello,

Yes, this feature has been removed while reworking the Painter to include the 2D acceleration, as it was not use in our examples or demos.
We are in the release process of the 1.11 version, so we probably won't be able to reintroduce it for this version. We'll handle it right after the release.

Sorry for this disagreement.

Regards,
Ludovic

@gbmbg
Copy link
Author

gbmbg commented Apr 16, 2025

Ok, so there is no other way to do the same thing in version 1.11 for now, right?
If yes we will continue to employ the version packed with buildroot kernel 2024.10 for now
Thanks for you kind and quick reply

@ldesroches
Copy link
Contributor

Yes, there is no way to crop images with 1.11. To get it, you will have to wait for the linux4microchip-2025.04 release and cherry-pick the extra patches we'll add on the master branch to reintroduce this feature.

@gbmbg
Copy link
Author

gbmbg commented Apr 16, 2025

Thanks again, I have another question but I think I will open another issue closing this one.

@gbmbg gbmbg closed this as completed Apr 16, 2025
@ldesroches
Copy link
Contributor

Hello,

Thanks to Cyrille, he quickly did a patch to reintroduce it. As it has no side effect, we can take it for the 1.11 release. The API is slightly different.

Regards,
Ludovic

@gbmbg
Copy link
Author

gbmbg commented Apr 17, 2025

Wow! Sounds great! Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants