Skip to content

Commit fe62330

Browse files
Enable minification for release builds
This also requires each module's package name to be unique.
1 parent 0ffa15b commit fe62330

File tree

8 files changed

+15
-4
lines changed

8 files changed

+15
-4
lines changed

app/build.gradle

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,13 @@ android {
2929
versionName "1.0"
3030
}
3131

32+
buildTypes {
33+
debug {}
34+
release {
35+
minifyEnabled true
36+
}
37+
}
38+
3239
compileOptions {
3340
sourceCompatibility = '1.8'
3441
targetCompatibility = '1.8'

features/assets/src/main/AndroidManifest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
<!-- This feature module only contains a single assets file relevant to the Android app. -->
1919
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
2020
xmlns:dist="http://schemas.android.com/apk/distribution"
21-
package="com.google.android.samples.dynamicfeatures.ondemand"
21+
package="com.google.android.samples.dynamicfeatures.ondemand.assets"
2222
split="assets">
2323

2424
<dist:module

features/java/src/main/AndroidManifest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717

1818
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
1919
xmlns:dist="http://schemas.android.com/apk/distribution"
20-
package="com.google.android.samples.dynamicfeatures.ondemand"
20+
package="com.google.android.samples.dynamicfeatures.ondemand.java"
2121
split="java">
2222

2323
<dist:module

features/java/src/main/java/com/google/android/samples/dynamicfeatures/ondemand/JavaSampleActivity.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@
1818

1919
import android.os.Bundle;
2020
import com.google.android.samples.dynamicfeatures.BaseSplitActivity;
21+
import com.google.android.samples.dynamicfeatures.ondemand.java.R;
22+
2123
import androidx.annotation.Nullable;
2224

2325
/** A simple activity displaying text written in Java. */

features/kotlin/src/main/AndroidManifest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717

1818
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
1919
xmlns:dist="http://schemas.android.com/apk/distribution"
20-
package="com.google.android.samples.dynamicfeatures.ondemand"
20+
package="com.google.android.samples.dynamicfeatures.ondemand.kotlin"
2121
split="kotlin">
2222

2323
<dist:module

features/kotlin/src/main/java/com/google/android/samples/dynamicfeatures/ondemand/KotlinSampleActivity.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ package com.google.android.samples.dynamicfeatures.ondemand
1818

1919
import android.os.Bundle
2020
import com.google.android.samples.dynamicfeatures.BaseSplitActivity
21+
import com.google.android.samples.dynamicfeatures.ondemand.kotlin.R
2122

2223
/** A simple Activity displaying some text, written in Kotlin. */
2324
class KotlinSampleActivity : BaseSplitActivity() {

features/native/src/main/AndroidManifest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717

1818
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
1919
xmlns:dist="http://schemas.android.com/apk/distribution"
20-
package="com.google.android.samples.dynamicfeatures.ondemand"
20+
package="com.google.android.samples.dynamicfeatures.ondemand.ccode"
2121
split="native">
2222

2323
<dist:module

features/native/src/main/java/com/google/android/samples/dynamicfeatures/ondemand/NativeSampleActivity.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ import android.os.Bundle
2020
import android.widget.TextView
2121
import com.google.android.play.core.splitinstall.SplitInstallHelper
2222
import com.google.android.samples.dynamicfeatures.BaseSplitActivity
23+
import com.google.android.samples.dynamicfeatures.ondemand.ccode.R
2324

2425
/** A simple activity displaying some text coming through via JNI. */
2526
class NativeSampleActivity : BaseSplitActivity() {

0 commit comments

Comments
 (0)