Ensure we always set the UIKit image properties from the main thread (fix SDWebImage#403, fix SDWebImage#417, fix SDWebImage#398)

Author: Olivier Poitrey

SDWebImage/MKAnnotationView+WebCache.m

@@ -49,15 +49,27 @@ - (void)setImageWithURL:(NSURL *)url placeholderImage:(UIImage *)placeholder opt
         __weak MKAnnotationView *wself = self;
         id<SDWebImageOperation> operation = [SDWebImageManager.sharedManager downloadWithURL:url options:options progress:nil completed:^(UIImage *image, NSError *error, SDImageCacheType cacheType, BOOL finished)
         {
-            __strong MKAnnotationView *sself = wself;
-            if (!sself) return;
-            if (image)
+            if (!wself) return;
+            void (^block)(void) = ^
             {
-                sself.image = image;
+                __strong MKAnnotationView *sself = wself;
+                if (!sself) return;
+                if (image)
+                {
+                    sself.image = image;
+                }
+                if (completedBlock && finished)
+                {
+                    completedBlock(image, error, cacheType);
+                }
+            };
+            if ([NSThread isMainThread])
+            {
+                block();
             }
-            if (completedBlock && finished)
+            else
             {
-                completedBlock(image, error, cacheType);
+                dispatch_sync(dispatch_get_main_queue(), block);
             }
         }];
         objc_setAssociatedObject(self, &operationKey, operation, OBJC_ASSOCIATION_RETAIN_NONATOMIC);

SDWebImage/UIButton+WebCache.m

@@ -48,15 +48,27 @@ - (void)setImageWithURL:(NSURL *)url forState:(UIControlState)state placeholderI
         __weak UIButton *wself = self;
         id<SDWebImageOperation> operation = [SDWebImageManager.sharedManager downloadWithURL:url options:options progress:nil completed:^(UIImage *image, NSError *error, SDImageCacheType cacheType, BOOL finished)
         {
-            __strong UIButton *sself = wself;
-            if (!sself) return;
-            if (image)
+            if (!wself) return;
+            void (^block)(void) = ^
             {
-                [sself setImage:image forState:state];
+                __strong UIButton *sself = wself;
+                if (!sself) return;
+                if (image)
+                {
+                    [sself setImage:image forState:state];
+                }
+                if (completedBlock && finished)
+                {
+                    completedBlock(image, error, cacheType);
+                }
+            };
+            if ([NSThread isMainThread])
+            {
+                block();
             }
-            if (completedBlock && finished)
+            else
             {
-                completedBlock(image, error, cacheType);
+                dispatch_sync(dispatch_get_main_queue(), block);
             }
         }];
         objc_setAssociatedObject(self, &operationKey, operation, OBJC_ASSOCIATION_RETAIN_NONATOMIC);
@@ -99,15 +111,27 @@ - (void)setBackgroundImageWithURL:(NSURL *)url forState:(UIControlState)state pl
         __weak UIButton *wself = self;
         id<SDWebImageOperation> operation = [SDWebImageManager.sharedManager downloadWithURL:url options:options progress:nil completed:^(UIImage *image, NSError *error, SDImageCacheType cacheType, BOOL finished)
         {
-            __strong UIButton *sself = wself;
-            if (!sself) return;
-            if (image)
+            if (!wself) return;
+            void (^block)(void) = ^
+            {
+                __strong UIButton *sself = wself;
+                if (!sself) return;
+                if (image)
+                {
+                    [sself setBackgroundImage:image forState:state];
+                }
+                if (completedBlock && finished)
+                {
+                    completedBlock(image, error, cacheType);
+                }
+            };
+            if ([NSThread isMainThread])
             {
-                [sself setBackgroundImage:image forState:state];
+                block();
             }
-            if (completedBlock && finished)
+            else
             {
-                completedBlock(image, error, cacheType);
+                dispatch_sync(dispatch_get_main_queue(), block);
             }
         }];
         objc_setAssociatedObject(self, &operationKey, operation, OBJC_ASSOCIATION_RETAIN_NONATOMIC);

SDWebImage/UIImageView+WebCache.m

@@ -54,16 +54,28 @@ - (void)setImageWithURL:(NSURL *)url placeholderImage:(UIImage *)placeholder opt
         __weak UIImageView *wself = self;
         id<SDWebImageOperation> operation = [SDWebImageManager.sharedManager downloadWithURL:url options:options progress:progressBlock completed:^(UIImage *image, NSError *error, SDImageCacheType cacheType, BOOL finished)
         {
-            __strong UIImageView *sself = wself;
-            if (!sself) return;
-            if (image)
+            if (!wself) return;
+            void (^block)(void) = ^
             {
-                sself.image = image;
-                [sself setNeedsLayout];
+                __strong UIImageView *sself = wself;
+                if (!sself) return;
+                if (image)
+                {
+                    sself.image = image;
+                    [sself setNeedsLayout];
+                }
+                if (completedBlock && finished)
+                {
+                    completedBlock(image, error, cacheType);
+                }
+            };
+            if ([NSThread isMainThread])
+            {
+                block();
             }
-            if (completedBlock && finished)
+            else
             {
-                completedBlock(image, error, cacheType);
+                dispatch_sync(dispatch_get_main_queue(), block);
             }
         }];
         objc_setAssociatedObject(self, &operationKey, operation, OBJC_ASSOCIATION_RETAIN_NONATOMIC);