Skip to content

Commit aa16141

Browse files
authored
Merge pull request kubernetes-sigs#465 from mengqiy/ghost
🏃 use 👻 for no release note commits
2 parents b88347b + 55c40b7 commit aa16141

File tree

3 files changed

+9
-1
lines changed

3 files changed

+9
-1
lines changed

VERSIONING.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,10 @@ a:
9292
- Patch fix: :bug: (`:bug:`)
9393
- Docs: :book: (`:book:`)
9494
- Infra/Tests/Other: :running: (`:running:`)
95+
- No release note: :ghost: (`:ghost:`)
96+
97+
Use :ghost: (no release note) only for the PRs that change or revert unreleased
98+
changes, which don't deserve a release note. Please don't abuse it.
9599

96100
You can also use the equivalent emoji directly, since GitHub doesn't
97101
render the `:xyz:` aliases in PR titles.

hack/release/common.sh

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ cr_major_pattern=":warning:|$(printf "\xe2\x9a\xa0")"
55
cr_minor_pattern=":sparkles:|$(printf "\xe2\x9c\xa8")"
66
cr_patch_pattern=":bug:|$(printf "\xf0\x9f\x90\x9b")"
77
cr_docs_pattern=":book:|$(printf "\xf0\x9f\x93\x96")"
8+
cr_no_release_note_pattern=":ghost:|$(printf "\xf0\x9f\x91\xbb")"
89
cr_other_pattern=":running:|$(printf "\xf0\x9f\x8f\x83")"
910

1011
# cr::symbol-type-raw turns :xyz: and the corresponding emoji
@@ -24,6 +25,9 @@ cr::symbol-type-raw() {
2425
@(${cr_docs_pattern})?('!'))
2526
echo "docs"
2627
;;
28+
@(${cr_no_release_note_pattern})?('!'))
29+
echo "no_release_note"
30+
;;
2731
@(${cr_other_pattern})?('!'))
2832
echo "other"
2933
;;

hack/release/release-notes.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ while read commit_word commit; do
5050
patch)
5151
bugfixes="${bugfixes}- ${pr_title} (#${pr_number})${NEWLINE}"
5252
;;
53-
docs|other)
53+
docs|no_release_note|other)
5454
# skip non-code-changes
5555
;;
5656
unknown)

0 commit comments

Comments
 (0)