Skip to content

[X86] Backport new intrinsic and instruction changes in AVX10.2 #133206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
phoebewang opened this issue Mar 27, 2025 · 6 comments
Closed

[X86] Backport new intrinsic and instruction changes in AVX10.2 #133206

phoebewang opened this issue Mar 27, 2025 · 6 comments

Comments

@phoebewang
Copy link
Contributor

This is a single request to backporting #131592, #132362, #132397, #132405, #132414, and #132426.

#131592 is saturation intrinsic naming change that aligned with GCC;
#132362 is a revert of prior merged new YMM rounding variants of existing instructions;
#132397, #132405, #132414, and #132426 remove the YMM rounding variants from new introduced AVX10.2 instruction. Together with #132362, they are to reflect the latest change of AVX10 white paper: https://cdrdv2.intel.com/v1/dl/getContent/784343

Although the changes look big, they are just straightforward removal or renaming, the risk is low. I think back porting to LLVM20 can reduce the scope of people who may use the unsupported instructions and future compatibility issues when switching LLVM20 to future version.

@phoebewang
Copy link
Contributor Author

@llvmbot
Copy link
Member

llvmbot commented Mar 27, 2025

Failed to cherry-pick: phoebewang@fa4e3e4

https://github.com/llvm/llvm-project/actions/runs/14099165159

Please manually backport the fix and push it to your github fork. Once this is done, please create a pull request

@llvmbot
Copy link
Member

llvmbot commented Mar 27, 2025

Failed to cherry-pick: phoebewang@74bbc44

https://github.com/llvm/llvm-project/actions/runs/14099184224

Please manually backport the fix and push it to your github fork. Once this is done, please create a pull request

@llvmbot
Copy link
Member

llvmbot commented Mar 27, 2025

@llvm/issue-subscribers-backend-x86

Author: Phoebe Wang (phoebewang)

This is a single request to backporting #131592, #132362, #132397, #132405, #132414, and #132426.

#131592 is saturation intrinsic naming change that aligned with GCC;
#132362 is a revert of prior merged new YMM rounding variants of existing instructions;
#132397, #132405, #132414, and #132426 remove the YMM rounding variants from new introduced AVX10.2 instruction. Together with #132362, they are to reflect the latest change of AVX10 white paper: https://cdrdv2.intel.com/v1/dl/getContent/784343

Although the changes look big, they are just straightforward removal or renaming, the risk is low. I think back porting to LLVM20 can reduce the scope of people who may use the unsupported instructions and future compatibility issues when switching LLVM20 to future version.

@tstellar
Copy link
Collaborator

What's the status of this?

@phoebewang
Copy link
Contributor Author

It's substituted by #135549, sorry I forgot to close it.

@github-project-automation github-project-automation bot moved this from Needs Review to Done in LLVM Release Status May 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

4 participants