Skip to content

[HLSL] Raise a diagnostic on Invalid CounterDirection #135672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
V-FEXrt opened this issue Apr 14, 2025 · 0 comments · Fixed by #137697
Closed

[HLSL] Raise a diagnostic on Invalid CounterDirection #135672

V-FEXrt opened this issue Apr 14, 2025 · 0 comments · Fixed by #137697
Assignees
@V-FEXrt
Labels
backend:DirectX HLSL HLSL Language Support

Comments

@V-FEXrt
Copy link
Contributor

V-FEXrt commented Apr 14, 2025

This issue supersedes #114130 which is being divided in half.

The second half is to raise a diagnostic when CounterDirection has been marked as valid. The design should be in alignment with this proposal and not the original issue as written.
@V-FEXrt V-FEXrt added the HLSL HLSL Language Support label Apr 14, 2025
@V-FEXrt V-FEXrt self-assigned this Apr 14, 2025
@V-FEXrt V-FEXrt mentioned this issue Apr 14, 2025
Closed
@V-FEXrt V-FEXrt moved this to Active in HLSL Support Apr 14, 2025
@V-FEXrt V-FEXrt mentioned this issue Apr 28, 2025
Merged
V-FEXrt added a commit that referenced this issue May 9, 2025
@V-FEXrt
[HLSL] Raise Diag for Invalid CounterDirection (#137697)
793bee4 
Fixes #135672

Raise a diagnostic in the post optimization validation pass as defined
in
https://github.com/llvm/wg-hlsl/blob/main/proposals/0022-resource-instance-analysis.md
@github-project-automation github-project-automation bot moved this from Active to Closed in HLSL Support May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@V-FEXrt V-FEXrt

Labels
backend:DirectX HLSL HLSL Language Support
Projects
HLSL Support
Status: Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[HLSL] Raise Diag for Invalid CounterDirection V-FEXrt/llvm-project
2 participants
@V-FEXrt @EugeneZelenko