Skip to content

[clang][PAC] Ensure that hasAddressDiscriminatedPointerAuth actually reports the truth for non trivial types #139210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ojhunt opened this issue May 9, 2025 · 2 comments
Open

[clang][PAC] Ensure that hasAddressDiscriminatedPointerAuth actually reports the truth for non trivial types #139210

ojhunt opened this issue May 9, 2025 · 2 comments
Labels
clang:frontend Language frontend issues, e.g. anything involving "Sema"

Comments

@ojhunt
Copy link
Contributor

ojhunt commented May 9, 2025

as in title, hasAddressDiscriminatedPointerAuth acts like it works on all types, but realistically does not, which makes it an error prone API. Either it should fail hard (or not be available) on types it does not handle correctly, or it should handle all types correctly.
@llvmbot llvmbot added the clang Clang issues not falling into any other category label May 9, 2025
@cor3ntin
Copy link
Contributor

cor3ntin commented May 9, 2025

Additionally, I don't think there is any test for isBitwiseCloneableType / __is_bitwise_cloneable

@EugeneZelenko EugeneZelenko added clang:frontend Language frontend issues, e.g. anything involving "Sema" and removed clang Clang issues not falling into any other category labels May 9, 2025
@llvmbot
Copy link
Member

llvmbot commented May 9, 2025

@llvm/issue-subscribers-clang-frontend

Author: Oliver Hunt (ojhunt)

as in title, hasAddressDiscriminatedPointerAuth acts like it works on all types, but realistically does not, which makes it an error prone API. Either it should fail hard (or not be available) on types it does not handle correctly, or it should handle all types correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clang:frontend Language frontend issues, e.g. anything involving "Sema"
Projects
Pointer Authentication Tasks
Status: No status
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cor3ntin @ojhunt @EugeneZelenko @llvmbot