Skip to content

"Assertion `!isa<ConstantExpr>(E)' failed." with compound literal #139160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
efriedma-quic opened this issue May 8, 2025 · 5 comments · May be fixed by #139479
Open

"Assertion `!isa<ConstantExpr>(E)' failed." with compound literal #139160

efriedma-quic opened this issue May 8, 2025 · 5 comments · May be fixed by #139479
Assignees
Labels
clang:frontend Language frontend issues, e.g. anything involving "Sema" crash Prefer [crash-on-valid] or [crash-on-invalid] good first issue https://github.com/llvm/llvm-project/contribute

Comments

@efriedma-quic
Copy link
Collaborator

Testcase:

struct A {int x[1]; };
A f();
typedef int *t[];
consteval int* f(int* x) { return x; }
int ** x = (t){f(f().x)};

Crashes with:

clang: clang/lib/AST/Expr.cpp:339: static clang::ConstantExpr *clang::ConstantExpr::Create(const clang::ASTContext &, clang::Expr *, clang::ConstantResultStorageKind, bool): Assertion `!isa<ConstantExpr>(E)' failed.
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace, preprocessed source, and associated run script.
Stack dump:
0.      Program arguments: clang -x c++ - -o - -S -std=c++20
1.      <stdin>:5:25: current parser token ';'
@EugeneZelenko EugeneZelenko added clang:frontend Language frontend issues, e.g. anything involving "Sema" crash Prefer [crash-on-valid] or [crash-on-invalid] and removed new issue labels May 8, 2025
@llvmbot
Copy link
Member

llvmbot commented May 8, 2025

@llvm/issue-subscribers-clang-frontend

Author: Eli Friedman (efriedma-quic)

Testcase:
struct A {int x[1]; };
A f();
typedef int *t[];
consteval int* f(int* x) { return x; }
int ** x = (t){f(f().x)};

Crashes with:

clang: clang/lib/AST/Expr.cpp:339: static clang::ConstantExpr *clang::ConstantExpr::Create(const clang::ASTContext &amp;, clang::Expr *, clang::ConstantResultStorageKind, bool): Assertion `!isa&lt;ConstantExpr&gt;(E)' failed.
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace, preprocessed source, and associated run script.
Stack dump:
0.      Program arguments: clang -x c++ - -o - -S -std=c++20
1.      &lt;stdin&gt;:5:25: current parser token ';'

@tbaederr tbaederr added the good first issue https://github.com/llvm/llvm-project/contribute label May 9, 2025
@llvmbot
Copy link
Member

llvmbot commented May 9, 2025

Hi!

This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:

  1. Check that no other contributor has already been assigned to this issue. If you believe that no one is actually working on it despite an assignment, ping the person. After one week without a response, the assignee may be changed.
  2. In the comments of this issue, request for it to be assigned to you, or just create a pull request after following the steps below. Mention this issue in the description of the pull request.
  3. Fix the issue locally.
  4. Run the test suite locally. Remember that the subdirectories under test/ create fine-grained testing targets, so you can e.g. use make check-clang-ast to only run Clang's AST tests.
  5. Create a Git commit.
  6. Run git clang-format HEAD~1 to format your changes.
  7. Open a pull request to the upstream repository on GitHub. Detailed instructions can be found in GitHub's documentation. Mention this issue in the description of the pull request.

If you have any further questions about this issue, don't hesitate to ask via a comment in the thread below.

@llvmbot
Copy link
Member

llvmbot commented May 9, 2025

@llvm/issue-subscribers-good-first-issue

Author: Eli Friedman (efriedma-quic)

Testcase:
struct A {int x[1]; };
A f();
typedef int *t[];
consteval int* f(int* x) { return x; }
int ** x = (t){f(f().x)};

Crashes with:

clang: clang/lib/AST/Expr.cpp:339: static clang::ConstantExpr *clang::ConstantExpr::Create(const clang::ASTContext &amp;, clang::Expr *, clang::ConstantResultStorageKind, bool): Assertion `!isa&lt;ConstantExpr&gt;(E)' failed.
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace, preprocessed source, and associated run script.
Stack dump:
0.      Program arguments: clang -x c++ - -o - -S -std=c++20
1.      &lt;stdin&gt;:5:25: current parser token ';'

@Mr-Anyone
Copy link

Mr-Anyone commented May 9, 2025

Hey, I'd love to work on this if that's okay. Thanks!

@AaronBallman
Copy link
Collaborator

Hey, I'd love to work on this if that's okay. Thanks!

I've assigned to you, thank you for looking into it!

Mr-Anyone added a commit to Mr-Anyone/llvm-project that referenced this issue May 11, 2025
Compound literals initializer-list should be a constant expression if
it is defined outside the body of a function.

Emit error instead of falling through tripping assertion error.

fixes llvm#139160
Mr-Anyone added a commit to Mr-Anyone/llvm-project that referenced this issue May 11, 2025
Compound literals initializer-list should be a constant expression if it is defined outside the body of a function.

Emit error instead of falling through tripping assertion error.

fixes llvm#139160
Mr-Anyone added a commit to Mr-Anyone/llvm-project that referenced this issue May 13, 2025
Compound literals initializer-list should be a constant expression if it is defined outside the body of a function.

Emit error instead of falling through tripping assertion error.

fixes llvm#139160
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang:frontend Language frontend issues, e.g. anything involving "Sema" crash Prefer [crash-on-valid] or [crash-on-invalid] good first issue https://github.com/llvm/llvm-project/contribute
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants