Skip to content

Add missing features for Haswell, too #63650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ms178 opened this issue Jul 3, 2023 · 2 comments
Closed

Add missing features for Haswell, too #63650

ms178 opened this issue Jul 3, 2023 · 2 comments

Comments

@ms178
Copy link

ms178 commented Jul 3, 2023

Looking at b026c9e and llvm/include/llvm/TargetParser/X86TargetParser.def in particular, I've noticed that the entries for Haswell lack some features: BMI2 and AES are supported on many client and server Haswell CPUs which are still in use today (appearently some Pentiums and Celerons of that generation don't support all of these - maybe a seperate target should be introduced for these low-end models ("haswell-noavx2") wheras the "haswell" target should gain these features by default?).

Also see this GCC bug entry for reference: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104683

@FreddyLeaf as he implemented the missing features for the other targets.

@llvmbot
Copy link
Member

llvmbot commented Jul 3, 2023

@llvm/issue-subscribers-backend-x86

@ms178
Copy link
Author

ms178 commented May 10, 2025

@ms178 ms178 closed this as completed May 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants