Prepare for Moodle 4.4 and PHP 8.2.

Author: lucaboesch

.github/workflows/ci.yml

@@ -33,6 +33,12 @@ jobs:
           - php: '8.2'
             moodle-branch: 'master'
             database: 'pgsql'
+          - php: '8.3'
+            moodle-branch: 'MOODLE_404_STABLE'
+            database: 'mariadb'
+          - php: '8.2'
+            moodle-branch: 'MOODLE_403_STABLE'
+            database: 'pgsql'
           - php: '8.1'
             moodle-branch: 'MOODLE_402_STABLE'
             database: 'mariadb'
@@ -45,7 +51,7 @@ jobs:
 
     steps:
       - name: Check out repository code
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           path: plugin
 
@@ -78,11 +84,6 @@ jobs:
         if: ${{ always() }}
         run: moodle-plugin-ci phplint
 
-      - name: PHP Copy/Paste Detector
-        continue-on-error: true # This step will show errors but will not fail
-        if: ${{ always() }}
-        run: moodle-plugin-ci phpcpd
-
       - name: PHP Mess Detector
         if: ${{ always() }}
         run: moodle-plugin-ci phpmd

classes/privacy/provider.php

@@ -31,7 +31,7 @@ class provider implements \core_privacy\local\metadata\null_provider {
      *
      * @return  string
      */
-    public static function get_reason() : string {
+    public static function get_reason(): string {
         return 'privacy:metadata';
     }
 }

lang/en/filter_embedquestion.php

@@ -39,8 +39,8 @@
 $string['errormaxmarknumber'] = 'The maximum mark must be a number.';
 $string['errornopermissions'] = 'You do not have permission to embed this question.';
 $string['errorunknownquestion'] = 'Unknown, or unsharable question.';
-$string['errorvariantoutofrange'] = 'Variant number must be a positive integer at most {$a}.';
 $string['errorvariantformat'] = 'Variant number must be a positive integer.';
+$string['errorvariantoutofrange'] = 'Variant number must be a positive integer at most {$a}.';
 $string['filtername'] = 'Embed questions';
 $string['generalfeedback_desc'] = 'Whether the general feedback should be shown by default in embedded questions.';
 $string['howquestionbehaves'] = 'How the question behaves';

tests/attempt_test.php

@@ -26,7 +26,7 @@
  * @covers    \filter_embedquestion\attempt
  * @covers    \filter_embedquestion\attempt_storage
  */
-class attempt_test extends \advanced_testcase {
+final class attempt_test extends \advanced_testcase {
 
     public function test_start_new_attempt_at_question_will_select_an_unused_question(): void {
         global $DB, $USER;

tests/cleanup_task_test.php

@@ -26,7 +26,7 @@
  * @license   http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  * @covers    \filter_embedquestion\task\cleanup_task
  */
-class cleanup_task_test extends \advanced_testcase {
+final class cleanup_task_test extends \advanced_testcase {
 
     public function test_cleanup_task(): void {
 

tests/external_test.php

@@ -25,7 +25,7 @@
  * @covers    \filter_embedquestion\external
  * @runTestsInSeparateProcesses
  */
-class external_test extends \advanced_testcase {
+final class external_test extends \advanced_testcase {
 
     public function setUp(): void {
         global $SCRIPT;

tests/filter_test.php

@@ -31,7 +31,7 @@
  * @license   http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  * @covers    \filter_embedquestion
  */
-class filter_test extends \advanced_testcase {
+final class filter_test extends \advanced_testcase {
 
     public function setUp(): void {
         parent::setUp();

tests/token_test.php

@@ -24,7 +24,7 @@
  * @license   http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  * @covers    \filter_embedquestion\token
  */
-class token_test extends \advanced_testcase {
+final class token_test extends \advanced_testcase {
 
     public function test_is_authorized_secret_token(): void {
         $this->resetAfterTest();

tests/utils_test.php

@@ -32,7 +32,7 @@
  * @license   http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  * @covers    \filter_embedquestion\utils
  */
-class utils_test extends \advanced_testcase {
+final class utils_test extends \advanced_testcase {
 
     public function test_get_category_by_idnumber(): void {
         $this->resetAfterTest();