Merge pull request #27 from jooj123/patch/set-correct-target

Set correct target for onChange callback when label is not used

Author: luqin

dist/react-icheck.js

@@ -284,6 +284,7 @@ var EnhancedSwitch = (function (_React$Component) {
           checked: checked
         });
       }
+
       if (this.props.onChange) {
         this.props.onChange(e, checked);
       }
@@ -321,8 +322,6 @@ var EnhancedSwitch = (function (_React$Component) {
         return;
       }
 
-      // let type = event.type;
-
       var newChecked = !this.refs.checkbox.checked;
 
       if (!('checked' in this.props)) {
@@ -334,7 +333,10 @@ var EnhancedSwitch = (function (_React$Component) {
 
       event.preventDefault();
       event.stopPropagation();
-      if (this.props.onChange && !this.props.label) {
+
+      if (this.props.onChange) {
+        // make sure <ins /> element is not target
+        event.target = this.refs.checkbox;
         this.props.onChange(event, newChecked);
       }
     }
@@ -454,7 +456,6 @@ var EnhancedSwitch = (function (_React$Component) {
         name: name,
         value: value,
         defaultChecked: props.defaultChecked,
-        // checked: !!checked,
         onChange: this.handleChange.bind(this),
         onBlur: this.handleBlur.bind(this),
         onFocus: this.handleFocus.bind(this)

dist/react-icheck.js.map

@@ -235,6 +235,7 @@ class EnhancedSwitch extends React.Component {
         checked,
       });
     }
+
     if (this.props.onChange) {
       this.props.onChange(e, checked);
     }
@@ -269,8 +270,6 @@ class EnhancedSwitch extends React.Component {
       return;
     }
 
-    // let type = event.type;
-
     let newChecked = !this.refs.checkbox.checked;
 
     if (!('checked' in this.props)) {
@@ -282,7 +281,10 @@ class EnhancedSwitch extends React.Component {
 
     event.preventDefault();
     event.stopPropagation();
-    if (this.props.onChange && !this.props.label) {
+
+    if (this.props.onChange) {
+      // make sure <ins /> element is not target
+      event.target = this.refs.checkbox;
       this.props.onChange(event, newChecked);
     }
   }
@@ -409,7 +411,6 @@ class EnhancedSwitch extends React.Component {
       name,
       value,
       defaultChecked: props.defaultChecked,
-      // checked: !!checked,
       onChange: this.handleChange.bind(this),
       onBlur: this.handleBlur.bind(this),
       onFocus: this.handleFocus.bind(this),