Skip to content

Commit df77f9c

Browse files
committed
Update readme and changelog
1 parent 8cd38ec commit df77f9c

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ CHANGELOG
44
[Next release](https://github.com/rebing/graphql-laravel/compare/v1.24.0...master)
55
------------
66
## Breaking changes
7-
- Featuring "performance by default", the new `lazyload_types` settings defaults to `true`. The breaking change is that this does not support type aliasing (if your types `$name` is different the one it's registered under). To still use aliasing, set it to `false`.
7+
- Featuring "performance by default", the new `lazyload_types` settings defaults to `true`. The breaking change is that this does not support type aliasing (if your types `$name` is different the one it's registered under) which includes pagination. To still use either, set it to `false`.
88
- The `UploadType` now has to be added manually to the `types` in your schema if you want to use it
99
- The `::getInstance()` method is gone
1010
- The order and arguments/types for resolvers has changed:
@@ -44,6 +44,7 @@ CHANGELOG
4444
- Replace global helper `is_lumen` with static class call `\Rebing\GraphQL\Helpers::isLumen`
4545

4646
### Fixed
47+
- The Paginator correctly inherits the types model so it can be used with `SelectFields` and still generates correct SQL queries [\#415](https://github.com/rebing/graphql-laravel/pull/415)
4748
- Arguments are now validation before they're passed to `authorize()` [\#413](https://github.com/rebing/graphql-laravel/pull/413)
4849
- File uploads now correctly work with batched requests [\#397](https://github.com/rebing/graphql-laravel/pull/397)
4950
- Path multi-level support for Schemas works again [\#358](https://github.com/rebing/graphql-laravel/pull/358)

Readme.md

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1569,9 +1569,11 @@ The following is not a bullet-proof list but should serve as a guide. It's not a
15691569
Lazy loading of types is enabled by default, having no drawback for small
15701570
projects but benfiting usages with many types.
15711571

1572-
If you however use aliasing, that the `$name` of a type does not match
1573-
it registered name, this does not work and you've to disable it by setting
1574-
`lazyload_types` to `false` in the configuration.
1572+
There are however scenarios where it's not supported:
1573+
- types using aliases
1574+
- built-in paginations via `GraphQL::pagination()` (which triggers the former)
1575+
1576+
In either case `lazyload_types` have to be set to `false`.
15751577

15761578
#### Example of aliasing **not** supported by lazy loading
15771579

0 commit comments

Comments
 (0)