Skip to content

Commit 6bb968c

Browse files
authored
Merge pull request kubernetes#124373 from neolit123/1.31-remove-deprecated-update-status-phase
kubeadm: remove the deprecated "update-status" phase of "join"
2 parents 573832a + 917c8d6 commit 6bb968c

File tree

1 file changed

+0
-28
lines changed

1 file changed

+0
-28
lines changed

cmd/kubeadm/app/cmd/phases/join/controlplanejoin.go

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ import (
2525
"k8s.io/kubernetes/cmd/kubeadm/app/cmd/options"
2626
"k8s.io/kubernetes/cmd/kubeadm/app/cmd/phases/workflow"
2727
cmdutil "k8s.io/kubernetes/cmd/kubeadm/app/cmd/util"
28-
kubeadmconstants "k8s.io/kubernetes/cmd/kubeadm/app/constants"
2928
etcdphase "k8s.io/kubernetes/cmd/kubeadm/app/phases/etcd"
3029
markcontrolplanephase "k8s.io/kubernetes/cmd/kubeadm/app/phases/markcontrolplane"
3130
etcdutil "k8s.io/kubernetes/cmd/kubeadm/app/util/etcd"
@@ -69,7 +68,6 @@ func NewControlPlaneJoinPhase() workflow.Phase {
6968
ArgsValidator: cobra.NoArgs,
7069
},
7170
newEtcdLocalSubphase(),
72-
newUpdateStatusSubphase(),
7371
newMarkControlPlaneSubphase(),
7472
},
7573
}
@@ -85,19 +83,6 @@ func newEtcdLocalSubphase() workflow.Phase {
8583
}
8684
}
8785

88-
func newUpdateStatusSubphase() workflow.Phase {
89-
return workflow.Phase{
90-
Name: "update-status",
91-
Short: fmt.Sprintf(
92-
"Register the new control-plane node into the ClusterStatus maintained in the %s ConfigMap (DEPRECATED)",
93-
kubeadmconstants.KubeadmConfigConfigMap,
94-
),
95-
Run: runUpdateStatusPhase,
96-
InheritFlags: getControlPlaneJoinPhaseFlags("update-status"),
97-
ArgsValidator: cobra.NoArgs,
98-
}
99-
}
100-
10186
func newMarkControlPlaneSubphase() workflow.Phase {
10287
return workflow.Phase{
10388
Name: "mark-control-plane",
@@ -159,19 +144,6 @@ func runEtcdPhase(c workflow.RunData) error {
159144
return nil
160145
}
161146

162-
func runUpdateStatusPhase(c workflow.RunData) error {
163-
data, ok := c.(JoinData)
164-
if !ok {
165-
return errors.New("control-plane-join phase invoked with an invalid data struct")
166-
}
167-
168-
if data.Cfg().ControlPlane != nil {
169-
fmt.Println("The 'update-status' phase is deprecated and will be removed in a future release. " +
170-
"Currently it performs no operation")
171-
}
172-
return nil
173-
}
174-
175147
func runMarkControlPlanePhase(c workflow.RunData) error {
176148
data, ok := c.(JoinData)
177149
if !ok {

0 commit comments

Comments
 (0)